Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477998

Re: ACPI-video: Fine-tuning for several function implementations

Show all headers | View raw

> Your patches happen to modify code maintained by me.  From my
> perspective the value of the changes made by them is marginal.

Thanks for another bit of interesting information.


> Nevertheless, I might take them if you made my life somewhat easier,

I am also looking for further approaches to help you there.


> so I've tried to tell you politely how to do that.

This feedback is generally fine.


> If you're not willing to do it,

My willingness is depending on also some factors.


> though, this is where it ends.

I hope that a bit more clarification can improve the situation.


> And attempts to convince me that I may not want my life to be easier
> after all are not likely to succeed.

We usually want that life will become more comfortable.

I chose to contribute something to Linux source files for this purpose.
My knowledge evolved in the way that I am using some tools for
static source code analysis. Such advanced tools can point various
change opportunities out. I picked a few special search patterns up.
It happened then that hundreds of source files were found which contain
update candidates. I am trying to inform the corresponding developers
about improvement possibilities in affected systems.


Further challenges are relevant then as usual.

* Handling of the search process and their results

* Communication between contributors


Search patterns can occasionally be categorised as "too special".
The software technology contains also the risk for showing "false positives".

The reactions of code reviewers are varying between rejection and acceptance.
Now I would like to determine again which details of the proposed changes
have got a higher chance for acceptance.

The discussed concrete patch series is just another example for usual
difficulties or more interesting software development challenges.
I hope that they can be resolved in a systematic way.
I sent analysis results as a series of small software updates. I find
it important to understand them also in the way that they belong to
software design patterns. I can imagine that it is harder to recognise
the involved patterns from the presented combination of update steps.

Would you like to check and clarify these patterns once more
before the desired improvements will happen (in a software area you maintain)?


So there are further constraints to consider. My software development experience
leaded me to a very specific kind of patch granularity here.
My software development interest evolved also in the way that I dared
to fiddle with the source files "drivers/acpi/processor_perflib.c"
and "drivers/acpi/processor_throttling.c" yesterday.
The consequence is that I would to publish a corresponding series
of 30 update steps for integration into another source code repository.
It seems that I need to wait a bit more for the next contribution attempt
before the change acceptance will fit to such an approach.

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/21] ACPI-video: Fine-tuning for several function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 01/21] ACPI-video: Use kmalloc_array() in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 02/21] ACPI-video: Return directly after a failed device query SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 18:50 +0200
  [PATCH 08/21] ACPI-video: Improve a size determination in  acpi_video_bus_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 07/21] ACPI-video: Rename jump labels in acpi_video_bus_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 11/21] ACPI-video: Rename jump labels in  acpi_video_bus_add_notify_handler() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:00 +0200
  [PATCH 14/21] ACPI-video: Improve a size determination in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 15/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 12/21] ACPI-video: Delete unnecessary if statement in  acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 18/21] ACPI-video: Rename jump labels in  acpi_video_init_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 13/21] ACPI-video: Improve a jump target in  acpi_video_switch_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 09/21] ACPI-video: Rename jump labels in acpi_video_register() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 16/21] ACPI-video: Rename jump labels in  acpi_video_device_enumerate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 19/21] ACPI-video: Rename a jump label in  acpi_video_device_lcd_query_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 21/21] ACPI-video: Improve a size determination in  acpi_video_bus_get_one_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 10/21] ACPI-video: Return directly after a failed  input_allocate_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 17/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_init_brightness() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 20/21] ACPI-video: Improve a size determination in  acpi_video_dev_register_backlight() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:10 +0200
  [PATCH 04/21] ACPI-video: Rename jump labels in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 06/21] ACPI-video: Move four assignments in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 05/21] ACPI-video: Delete an unnecessary initialisation in  acpi_video_get_levels() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:30 +0200
  [PATCH 03/21] ACPI-video: Delete an error message for a failed  kzalloc() call SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-05 19:40 +0200
  Re: [PATCH 00/21] ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-05 23:50 +0200
    Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-06 05:30 +0200
      Re: ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-06 13:30 +0200
        Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-06 16:20 +0200
          Re: ACPI-video: Fine-tuning for several function implementations "Rafael J. Wysocki" <rafael@kernel.org> - 2016-09-06 23:10 +0200
            Re: ACPI-video: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-07 08:50 +0200

csiph-web