Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1476507

[PATCH 4/5] gpio: pca953x: remove an unused variable

Show all headers | View raw

The chip_type variable in struct pca953x_chip is no longer required.

Remove it.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpio-pca953x.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index b64a7bb..86676dd 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -129,7 +129,6 @@ struct pca953x_chip {
 	struct i2c_client *client;
 	struct gpio_chip gpio_chip;
 	const char *const *names;
-	int	chip_type;
 	unsigned long driver_data;
 
 	struct pca953x_offset *offset;
@@ -760,8 +759,6 @@ static int pca953x_probe(struct i2c_client *client,
 		}
 	}
 
-	chip->chip_type = PCA_CHIP_TYPE(chip->driver_data);
-
 	mutex_init(&chip->i2c_lock);
 
 	/* initialize cached registers from their original values.
@@ -774,7 +771,7 @@ static int pca953x_probe(struct i2c_client *client,
 	else if (chip->gpio_chip.ngpio >= 24)
 		chip->write_regs = pca953x_write_regs_24;
 
-	if (chip->chip_type == PCA953X_TYPE)
+	if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE)
 		ret = device_pca953x_init(chip, invert);
 	else
 		ret = device_pca957x_init(chip, invert);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] gpio: pca953x: code refactoring Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
  [PATCH 4/5] gpio: pca953x: remove an unused variable Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
  [PATCH 5/5] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
  [PATCH 1/5] gpio: pca953x: coding style fixes Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
    Re: [PATCH 1/5] gpio: pca953x: coding style fixes Linus Walleij <linus.walleij@linaro.org> - 2016-09-08 00:00 +0200
      Re: [PATCH 1/5] gpio: pca953x: coding style fixes Linus Walleij <linus.walleij@linaro.org> - 2016-09-08 01:20 +0200
  [PATCH 3/5] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
  [PATCH 2/5] gpio: pca953x: code shrink Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-05 16:40 +0200
    Re: [PATCH 2/5] gpio: pca953x: code shrink Geert Uytterhoeven <geert@linux-m68k.org> - 2016-09-05 16:50 +0200
    Re: [PATCH 2/5] gpio: pca953x: code shrink Linus Walleij <linus.walleij@linaro.org> - 2016-09-08 00:10 +0200
  Re: [PATCH 0/5] gpio: pca953x: code refactoring Linus Walleij <linus.walleij@linaro.org> - 2016-09-08 00:10 +0200

csiph-web