Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1471506

Re: [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing

From Sebastian Reichel <sre@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing
Date 2016-08-29 02:50 +0200
Message-ID <sbiVX-kL-1@gated-at.bofh.it> (permalink)
References <sbcnw-4H8-31@gated-at.bofh.it> <sbcnw-4H8-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi,

On Sun, Aug 28, 2016 at 07:34:46PM +0200, Paul Kocialkowski wrote:
> When the charger is missing (disconnected), it is safe to assume that
> the charger chip is no charging.
> 
> This is especially relevant when a status GPIO is present and the
> charger is getting disconnected. bq24735_charger_is_charging will be
> triggered due to the interrupt then, it will attempt to read whether it
> is charging through i2c, which will fail as the charger is disconnected.
> 
> This also fixes that specific issue.

Thanks, I queued this one into my for-next branch.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup Paul Kocialkowski <contact@paulk.fr> - 2016-08-28 19:50 +0200
  [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing Paul Kocialkowski <contact@paulk.fr> - 2016-08-28 19:50 +0200
    Re: [PATCH 2/2] power: bq24735-charger: Assume not charging when  charger is missing Sebastian Reichel <sre@kernel.org> - 2016-08-29 02:50 +0200
  Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with  initial input setup Sebastian Reichel <sre@kernel.org> - 2016-08-29 02:40 +0200
    Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with  initial input setup Paul Kocialkowski <contact@paulk.fr> - 2016-08-29 20:20 +0200

csiph-web