Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472037

Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Le lundi 29 août 2016 à 02:36 +0200, Sebastian Reichel a écrit :
> Hi,
> 
> On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote:
> > 
> > This requests the status GPIO with initial input setup. it is required
> > to read the GPIO status at probe time and thus correctly avoid sending
> > i2c messages when AC is not plugged.
> > 
> > When requesting the GPIO without initial input setup, it always reads 0
> > which causes probe to fail as it assumes the charger is connected, sends
> > i2c messages and fails.
> 
> Please convert the driver to devm_gpiod_get instead.

Sure thing, see v2.

Thanks!

-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup Paul Kocialkowski <contact@paulk.fr> - 2016-08-28 19:50 +0200
  [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing Paul Kocialkowski <contact@paulk.fr> - 2016-08-28 19:50 +0200
    Re: [PATCH 2/2] power: bq24735-charger: Assume not charging when  charger is missing Sebastian Reichel <sre@kernel.org> - 2016-08-29 02:50 +0200
  Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with  initial input setup Sebastian Reichel <sre@kernel.org> - 2016-08-29 02:40 +0200
    Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with  initial input setup Paul Kocialkowski <contact@paulk.fr> - 2016-08-29 20:20 +0200

csiph-web