Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470144

Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long
Date 2016-08-25 15:30 +0200
Message-ID <sa2Tf-1tU-29@gated-at.bofh.it> (permalink)
References <s96YV-4v1-5@gated-at.bofh.it> <s96YV-4v1-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 23 Aug 2016, Nicolai Stange wrote:

> Right now, being of type unsigned long long, the clc local variable in
> clockevents_program_event() is unnecessarily wide as it gets cast to
> unsigned long anyway.

Congrats! You just broke 32bit systems. When delta is sufficiently large then
the mult overflows....
 
Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long Nicolai Stange <nicstange@gmail.com> - 2016-08-23 01:40 +0200
  Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn  clc into unsigned long Thomas Gleixner <tglx@linutronix.de> - 2016-08-25 15:30 +0200
    Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long Nicolai Stange <nicstange@gmail.com> - 2016-08-27 17:30 +0200

csiph-web