Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470144

Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long

Path csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long
Date Thu, 25 Aug 2016 15:30:01 +0200
Message-ID <sa2Tf-1tU-29@gated-at.bofh.it> (permalink)
References <s96YV-4v1-5@gated-at.bofh.it> <s96YV-4v1-9@gated-at.bofh.it>
User-Agent Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 12
Organization linux.* mail to news gateway
X-Original-Cc John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org
X-Original-Date Thu, 25 Aug 2016 15:20:59 +0200 (CEST)
X-Original-Message-ID <alpine.DEB.2.20.1608251519080.5714@nanos>
X-Original-References <20160822233320.4548-1-nicstange@gmail.com> <20160822233320.4548-15-nicstange@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1470144

Show key headers only | View raw


On Tue, 23 Aug 2016, Nicolai Stange wrote:

> Right now, being of type unsigned long long, the clc local variable in
> clockevents_program_event() is unnecessarily wide as it gets cast to
> unsigned long anyway.

Congrats! You just broke 32bit systems. When delta is sufficiently large then
the mult overflows....
 
Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long Nicolai Stange <nicstange@gmail.com> - 2016-08-23 01:40 +0200
  Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn  clc into unsigned long Thomas Gleixner <tglx@linutronix.de> - 2016-08-25 15:30 +0200
    Re: [RFC v4 14/22] clockevents: clockevents_program_event(): turn clc into unsigned long Nicolai Stange <nicstange@gmail.com> - 2016-08-27 17:30 +0200

csiph-web