Re: [PATCH] x86/platform/UV: Clean up the UV APIC code

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/platform/UV: Clean up the UV APIC code
Date	2017-01-14 14:20 +0100
Message-ID	<sZwpr-6pM-1@gated-at.bofh.it> (permalink)
References	<sZbXI-2vV-23@gated-at.bofh.it> <sZc7t-2zn-21@gated-at.bofh.it> <sZrpL-3gr-7@gated-at.bofh.it> <sZrSO-3Es-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-01-14 at 09:26 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@kernel.org> wrote:
[]
> In particular the random line breaks, apparently to pacify checkpatch, were
> horribly widespread. I just made the lines longer - that's still more readable
> than the multi-line horror that was there before.
[]
> arch/x86/kernel/apic/x2apic_uv_x.c |  500 ++++++++++++++++++-------------------
[]
> -	pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n",
> -		oem_id, oem_table_id, uv_system_type,
> -		uv_min_hub_revision_id, uv_apic);
> +	pr_info("UV: OEM IDs %s/%s, System/HUB Types %d/%d, uv_apic %d\n", oem_id, oem_table_id, uv_system_type, uv_min_hub_revision_id, uv_apic);

140+ chars on a single line.

Is this really better or easier to read?

Long lines make it harder to humans to verify
format and arguments used in printf type calls.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] x86/platform/UV: Add Support for UV4 Hubless NMIs Mike Travis <travis@sgi.com> - 2017-01-13 16:40 +0100
  Re: [PATCH 4/8] x86/platform/UV: Add Support for UV4 Hubless NMIs Ingo Molnar <mingo@kernel.org> - 2017-01-14 09:00 +0100
    Re: [PATCH] x86/platform/UV: Clean up the UV APIC code Joe Perches <joe@perches.com> - 2017-01-14 14:20 +0100

csiph-web