Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

From	Inki Dae <inki.dae@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board
Date	2017-01-11 09:50 +0100
Message-ID	<sYmLw-4GO-19@gated-at.bofh.it> (permalink)
References	<sYkJI-3kI-3@gated-at.bofh.it> <sYkJI-3kI-15@gated-at.bofh.it> <sYkJI-3kI-13@gated-at.bofh.it> <sYlPr-48g-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>
>> This patch add the panel device tree node for S6E3HA2 display
>> controller to TM2 dts.
>>
>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index ddba2f8..6d362f9 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -18,6 +18,18 @@
>>  	compatible = "samsung,tm2", "samsung,exynos5433";
>>  };
>>  
>> +&dsi {
>> +	panel@0 {
>> +		compatible = "samsung,s6e3ha2";
>> +		reg = <0>;
>> +		vdd3-supply = <&ldo27_reg>;
>> +		vci-supply = <&ldo28_reg>;
>> +		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>> +		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>> +		te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
> The same here (as in 1st comment) , te-gpios should be dropper - decon
> uses hw-trigger.

Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.

Thanks.

> 
> Regards
> Andrzej
>> +	};
>> +};
>> +
>>  &hsi2c_9 {
>>  	status = "okay";
>>  
> 
> 
> 
>

Thread

[PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-01-11 07:40 +0100
  Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 08:50 +0100
    Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board Inki Dae <inki.dae@samsung.com> - 2017-01-11 09:50 +0100
      Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 10:40 +0100
        Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 11:30 +0100
        Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100
    Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100
      Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel  device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100

csiph-web