Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1556223 > unrolled thread
| Started by | Hoegeun Kwon <hoegeun.kwon@samsung.com> |
|---|---|
| First post | 2017-01-11 07:40 +0100 |
| Last post | 2017-01-11 11:30 +0100 |
| Articles | 8 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-01-11 07:40 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 08:50 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Inki Dae <inki.dae@samsung.com> - 2017-01-11 09:50 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 10:40 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-11 11:30 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100
Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board hoegeun kwon <hoegeun.kwon@samsung.com> - 2017-01-11 11:30 +0100
| From | Hoegeun Kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-01-11 07:40 +0100 |
| Subject | [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board |
| Message-ID | <sYkJI-3kI-13@gated-at.bofh.it> |
From: Hyungwon Hwang <human.hwang@samsung.com>
This patch add the panel device tree node for S6E3HA2 display
controller to TM2 dts.
Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
---
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index ddba2f8..6d362f9 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -18,6 +18,18 @@
compatible = "samsung,tm2", "samsung,exynos5433";
};
+&dsi {
+ panel@0 {
+ compatible = "samsung,s6e3ha2";
+ reg = <0>;
+ vdd3-supply = <&ldo27_reg>;
+ vci-supply = <&ldo28_reg>;
+ reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
+ enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+ te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&hsi2c_9 {
status = "okay";
--
1.9.1
[toc] | [next] | [standalone]
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2017-01-11 08:50 +0100 |
| Message-ID | <sYlPr-48g-7@gated-at.bofh.it> |
| In reply to | #1556223 |
On 11.01.2017 07:33, Hoegeun Kwon wrote:
> From: Hyungwon Hwang <human.hwang@samsung.com>
>
> This patch add the panel device tree node for S6E3HA2 display
> controller to TM2 dts.
>
> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> index ddba2f8..6d362f9 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
> @@ -18,6 +18,18 @@
> compatible = "samsung,tm2", "samsung,exynos5433";
> };
>
> +&dsi {
> + panel@0 {
> + compatible = "samsung,s6e3ha2";
> + reg = <0>;
> + vdd3-supply = <&ldo27_reg>;
> + vci-supply = <&ldo28_reg>;
> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
The same here (as in 1st comment) , te-gpios should be dropper - decon
uses hw-trigger.
Regards
Andrzej
> + };
> +};
> +
> &hsi2c_9 {
> status = "okay";
>
[toc] | [prev] | [next] | [standalone]
| From | Inki Dae <inki.dae@samsung.com> |
|---|---|
| Date | 2017-01-11 09:50 +0100 |
| Message-ID | <sYmLw-4GO-19@gated-at.bofh.it> |
| In reply to | #1556252 |
2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>
>> This patch add the panel device tree node for S6E3HA2 display
>> controller to TM2 dts.
>>
>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index ddba2f8..6d362f9 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -18,6 +18,18 @@
>> compatible = "samsung,tm2", "samsung,exynos5433";
>> };
>>
>> +&dsi {
>> + panel@0 {
>> + compatible = "samsung,s6e3ha2";
>> + reg = <0>;
>> + vdd3-supply = <&ldo27_reg>;
>> + vci-supply = <&ldo28_reg>;
>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
> The same here (as in 1st comment) , te-gpios should be dropper - decon
> uses hw-trigger.
Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.
Thanks.
>
> Regards
> Andrzej
>> + };
>> +};
>> +
>> &hsi2c_9 {
>> status = "okay";
>>
>
>
>
>
[toc] | [prev] | [next] | [standalone]
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2017-01-11 10:40 +0100 |
| Message-ID | <sYnxT-5ch-7@gated-at.bofh.it> |
| In reply to | #1556287 |
On 11.01.2017 09:40, Inki Dae wrote:
>
> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>>
>>> This patch add the panel device tree node for S6E3HA2 display
>>> controller to TM2 dts.
>>>
>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> index ddba2f8..6d362f9 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> @@ -18,6 +18,18 @@
>>> compatible = "samsung,tm2", "samsung,exynos5433";
>>> };
>>>
>>> +&dsi {
>>> + panel@0 {
>>> + compatible = "samsung,s6e3ha2";
>>> + reg = <0>;
>>> + vdd3-supply = <&ldo27_reg>;
>>> + vci-supply = <&ldo28_reg>;
>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>> uses hw-trigger.
> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.
>
> Thanks.
OK, I forgot it was not yet ported to mainline.
Regards
Andrzej
>
>> Regards
>> Andrzej
>>> + };
>>> +};
>>> +
>>> &hsi2c_9 {
>>> status = "okay";
>>>
>>
>>
>>
>
[toc] | [prev] | [next] | [standalone]
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Date | 2017-01-11 11:30 +0100 |
| Message-ID | <sYokh-5Hu-5@gated-at.bofh.it> |
| In reply to | #1556321 |
On 11.01.2017 11:23, hoegeun kwon wrote:
>
> On 01/11/2017 06:39 PM, Andrzej Hajda wrote:
>> On 11.01.2017 09:40, Inki Dae wrote:
>>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
>>>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>>>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>>>>
>>>>> This patch add the panel device tree node for S6E3HA2 display
>>>>> controller to TM2 dts.
>>>>>
>>>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>>>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>>>> 1 file changed, 12 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>>> index ddba2f8..6d362f9 100644
>>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>>> @@ -18,6 +18,18 @@
>>>>> compatible = "samsung,tm2", "samsung,exynos5433";
>>>>> };
>>>>>
>>>>> +&dsi {
>>>>> + panel@0 {
>>>>> + compatible = "samsung,s6e3ha2";
>>>>> + reg = <0>;
>>>>> + vdd3-supply = <&ldo27_reg>;
>>>>> + vci-supply = <&ldo28_reg>;
>>>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>>>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>>>> uses hw-trigger.
>>> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.
>>>
>>> Thanks.
>> OK, I forgot it was not yet ported to mainline.
>>
>> Regards
>> Andrzej
> I received a reply while I was writing the mail.
> so, how about removing te-gpios later?
I think this is a good solution, just do not forget to change it to
optional in bindings, to make it removable.
Regards
Andrzej
[toc] | [prev] | [next] | [standalone]
| From | hoegeun kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-01-11 11:30 +0100 |
| Message-ID | <sYokh-5Hu-7@gated-at.bofh.it> |
| In reply to | #1556321 |
On 01/11/2017 06:39 PM, Andrzej Hajda wrote:
> On 11.01.2017 09:40, Inki Dae wrote:
>> 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:
>>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>>>
>>>> This patch add the panel device tree node for S6E3HA2 display
>>>> controller to TM2 dts.
>>>>
>>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> ---
>>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> index ddba2f8..6d362f9 100644
>>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>>> @@ -18,6 +18,18 @@
>>>> compatible = "samsung,tm2", "samsung,exynos5433";
>>>> };
>>>>
>>>> +&dsi {
>>>> + panel@0 {
>>>> + compatible = "samsung,s6e3ha2";
>>>> + reg = <0>;
>>>> + vdd3-supply = <&ldo27_reg>;
>>>> + vci-supply = <&ldo28_reg>;
>>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>>> uses hw-trigger.
>> Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.
>>
>> Thanks.
> OK, I forgot it was not yet ported to mainline.
>
> Regards
> Andrzej
I received a reply while I was writing the mail.
so, how about removing te-gpios later?
Best Regards,
Hoegeun
>
>>> Regards
>>> Andrzej
>>>> + };
>>>> +};
>>>> +
>>>> &hsi2c_9 {
>>>> status = "okay";
>>>>
>>>
>>>
>
>
[toc] | [prev] | [next] | [standalone]
| From | hoegeun kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-01-11 11:30 +0100 |
| Message-ID | <sYokh-5Hu-19@gated-at.bofh.it> |
| In reply to | #1556252 |
On 01/11/2017 04:46 PM, Andrzej Hajda wrote:
> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>
>> This patch add the panel device tree node for S6E3HA2 display
>> controller to TM2 dts.
>>
>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index ddba2f8..6d362f9 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -18,6 +18,18 @@
>> compatible = "samsung,tm2", "samsung,exynos5433";
>> };
>>
>> +&dsi {
>> + panel@0 {
>> + compatible = "samsung,s6e3ha2";
>> + reg = <0>;
>> + vdd3-supply = <&ldo27_reg>;
>> + vci-supply = <&ldo28_reg>;
>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
> The same here (as in 1st comment) , te-gpios should be dropper - decon
> uses hw-trigger.
Hi Andrzej,
Thanks for your quick review.
Reasonable to remove te-gpios property,
The Tizen public already has [1] your patch applied and te-gpios removed.
So I will add [1] to the V9 patch.
[1]
https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900
Best Regards,
Hoegeun
>
> Regards
> Andrzej
>> + };
>> +};
>> +
>> &hsi2c_9 {
>> status = "okay";
>>
>
>
>
[toc] | [prev] | [next] | [standalone]
| From | hoegeun kwon <hoegeun.kwon@samsung.com> |
|---|---|
| Date | 2017-01-11 11:30 +0100 |
| Message-ID | <sYokh-5Hu-21@gated-at.bofh.it> |
| In reply to | #1556377 |
On 01/11/2017 06:51 PM, hoegeun kwon wrote:
>
>
> On 01/11/2017 04:46 PM, Andrzej Hajda wrote:
>> On 11.01.2017 07:33, Hoegeun Kwon wrote:
>>> From: Hyungwon Hwang <human.hwang@samsung.com>
>>>
>>> This patch add the panel device tree node for S6E3HA2 display
>>> controller to TM2 dts.
>>>
>>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com>
>>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> ---
>>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> index ddba2f8..6d362f9 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>>> @@ -18,6 +18,18 @@
>>> compatible = "samsung,tm2", "samsung,exynos5433";
>>> };
>>> +&dsi {
>>> + panel@0 {
>>> + compatible = "samsung,s6e3ha2";
>>> + reg = <0>;
>>> + vdd3-supply = <&ldo27_reg>;
>>> + vci-supply = <&ldo28_reg>;
>>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
>>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
>>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
>> The same here (as in 1st comment) , te-gpios should be dropper - decon
>> uses hw-trigger.
>
> Hi Andrzej,
>
> Thanks for your quick review.
>
> Reasonable to remove te-gpios property,
> The Tizen public already has [1] your patch applied and te-gpios removed.
> So I will add [1] to the V9 patch.
>
> [1]
> https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900
I'm sorry URL address is wrong.
Correct address below:
[1]
https://git.tizen.org/cgit/platform/kernel/linux-exynos/commit/?h=tizen&id=468769bf6abbaaed2547b8c43e989ab5dc787900
Regards,
Hoegeun
>
> Best Regards,
> Hoegeun
>
>>
>> Regards
>> Andrzej
>>> + };
>>> +};
>>> +
>>> &hsi2c_9 {
>>> status = "okay";
>>
>>
>>
>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web