[PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int

From	Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int
Date	2017-01-09 08:50 +0100
Message-ID	<sXCSl-1et-1@gated-at.bofh.it> (permalink)
References	<sUbYl-GW-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-1
> echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat
-bash: echo: write error: Invalid argument
> echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat
> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-2147483648

but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER"

v2: simplify to just proc_douintvec
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
 net/ipv4/sysctl_net_ipv4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 80bc36b..566cfc5 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -958,7 +958,7 @@ static struct ctl_table ipv4_net_table[] = {
 		.data		= &init_net.ipv4.sysctl_tcp_notsent_lowat,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_douintvec,
 	},
 #ifdef CONFIG_IP_ROUTE_MULTIPATH
 	{
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int Pavel Tikhomirov <ptikhomirov@virtuozzo.com> - 2017-01-09 08:50 +0100
  Re: [PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as  true unsigned int David Miller <davem@davemloft.net> - 2017-01-09 22:50 +0100

csiph-web