Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554129 > unrolled thread
| Started by | Pavel Tikhomirov <ptikhomirov@virtuozzo.com> |
|---|---|
| First post | 2017-01-09 08:50 +0100 |
| Last post | 2017-01-09 22:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int Pavel Tikhomirov <ptikhomirov@virtuozzo.com> - 2017-01-09 08:50 +0100
Re: [PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int David Miller <davem@davemloft.net> - 2017-01-09 22:50 +0100
| From | Pavel Tikhomirov <ptikhomirov@virtuozzo.com> |
|---|---|
| Date | 2017-01-09 08:50 +0100 |
| Subject | [PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int |
| Message-ID | <sXCSl-1et-1@gated-at.bofh.it> |
> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-1
> echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat
-bash: echo: write error: Invalid argument
> echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat
> cat /proc/sys/net/ipv4/tcp_notsent_lowat
-2147483648
but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER"
v2: simplify to just proc_douintvec
Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
---
net/ipv4/sysctl_net_ipv4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 80bc36b..566cfc5 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -958,7 +958,7 @@ static struct ctl_table ipv4_net_table[] = {
.data = &init_net.ipv4.sysctl_tcp_notsent_lowat,
.maxlen = sizeof(unsigned int),
.mode = 0644,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_douintvec,
},
#ifdef CONFIG_IP_ROUTE_MULTIPATH
{
--
2.9.3
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-01-09 22:50 +0100 |
| Subject | Re: [PATCH v2] ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int |
| Message-ID | <sXPZf-ZK-9@gated-at.bofh.it> |
| In reply to | #1554129 |
From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com> Date: Mon, 9 Jan 2017 10:45:49 +0300 >> cat /proc/sys/net/ipv4/tcp_notsent_lowat > -1 >> echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat > -bash: echo: write error: Invalid argument >> echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat >> cat /proc/sys/net/ipv4/tcp_notsent_lowat > -2147483648 > > but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER" > > v2: simplify to just proc_douintvec > Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web