Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552601

Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25

Show all headers | View raw

On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote:
> On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote:
>> From: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E.
> 
> Please describe what is exactly wrong and how it affects the
> system/user. This is going to the fixes so it needs a good explanation.

When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E.
[1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")

After checking the highest version of schematic document of both TM2 and TM2E,
there is no difference of ldo23/ldo25 on both TM2 and TM2E.
- ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. 
- ldo25 isn't used on TM2/TM2E. (not connected)

Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board.
this patch does not affect the operation to system/user.

> 
>>
>> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
>> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts  |  7 ++++---
>>  arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 10 ----------
>>  2 files changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> index 3b5215c..e8971f4 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
>> @@ -504,9 +504,9 @@
>>  			};
>>  
>>  			ldo23_reg: LDO23 {
>> -				regulator-name = "CAM_SEN_CORE_1.2V_AP";
>> +				regulator-name = "CAM_SEN_CORE_1.05V_AP";
>>  				regulator-min-microvolt = <1050000>;
>> -				regulator-max-microvolt = <1200000>;
>> +				regulator-max-microvolt = <1050000>;
>>  			};
>>  
>>  			ldo24_reg: LDO24 {
>> @@ -516,9 +516,10 @@
>>  			};
>>  
>>  			ldo25_reg: LDO25 {
>> -				regulator-name = "CAM_SEN_A2.8V_AP";
>> +				regulator-name = "UNUSED_LDO25";
>>  				regulator-min-microvolt = <2800000>;
>>  				regulator-max-microvolt = <2800000>;
>> +				regulator-always-off;
> 
> Don't add it. See my other patch.

OK. After completing the kernel booting, the unused regulators will be off.

> 
> Best regards,
> Krzysztof
> 
>>  			};
>>  
>>  			ldo26_reg: LDO26 {
>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> index 1db4e7f..854c583 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts
>> @@ -18,16 +18,6 @@
>>  	compatible = "samsung,tm2e", "samsung,exynos5433";
>>  };
>>  
>> -&ldo23_reg {
>> -	regulator-name = "CAM_SEN_CORE_1.025V_AP";
>> -	regulator-max-microvolt = <1050000>;
>> -};
>> -
>> -&ldo25_reg {
>> -	regulator-name = "UNUSED_LDO25";
>> -	regulator-always-off;
>> -};
>> -
>>  &ldo31_reg {
>>  	regulator-name = "TSP_VDD_1.8V_AP";
>>  	regulator-min-microvolt = <1800000>;
>> -- 
>> 2.7.4
>>
> 
> 
> 


-- 
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of  ldo23 and ldo25 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-06 05:10 +0100
  Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 08:50 +0100
    Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-06 09:40 +0100
      Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 10:00 +0100
        Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-06 10:10 +0100
          Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 10:20 +0100

csiph-web