Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552615

Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25

Show all headers | View raw

On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote:
> On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote:
> > On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote:
> >> From: Chanwoo Choi <cw00.choi@samsung.com>
> >>
> >> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E.
> > 
> > Please describe what is exactly wrong and how it affects the
> > system/user. This is going to the fixes so it needs a good explanation.
> 
> When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E.
> [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
> 
> After checking the highest version of schematic document of both TM2 and TM2E,
> there is no difference of ldo23/ldo25 on both TM2 and TM2E.
> - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. 
> - ldo25 isn't used on TM2/TM2E. (not connected)
> 
> Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board.
> this patch does not affect the operation to system/user.

If it does not affect anyone (including TM2/TM2E) then this do not have
to be a fix. Am I right?

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of  ldo23 and ldo25 Jaechul Lee <jcsing.lee@samsung.com> - 2017-01-06 05:10 +0100
  Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 08:50 +0100
    Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-06 09:40 +0100
      Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 10:00 +0100
        Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-06 10:10 +0100
          Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong  information of ldo23 and ldo25 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-06 10:20 +0100

csiph-web