[PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch

From	Junichi Nomura <j-nomura@ce.jp.nec.com>
Newsgroups	linux.kernel
Subject	[PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch
Date	2017-01-05 02:50 +0100
Message-ID	<sW5lL-4mv-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We allocate struct ucode_patch here.

"size" is a size of microcode data and used for kmemdup() later
in this function.

Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index aee3cb5..042f329 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -150,7 +150,7 @@ static struct ucode_patch *__alloc_microcode_buf(void *data, unsigned int size)
 {
 	struct ucode_patch *p;
 
-	p = kzalloc(size, GFP_KERNEL);
+	p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);
 	if (!p)
 		return ERR_PTR(-ENOMEM);
 
-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-05 02:50 +0100
  Re: [PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-05 11:30 +0100
  Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 18:50 +0100
    Re: [PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-06 01:00 +0100
      Re: [PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-06 01:10 +0100
        Re: [PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-06 01:20 +0100
          Re: [PATCH] x86/microcode/intel: Fix allocation size of struct  ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-06 12:00 +0100
  [tip:x86/urgent] x86/microcode/intel: Fix allocation size of struct  ucode_patch tip-bot for Junichi Nomura <tipbot@zytor.com> - 2017-01-09 23:20 +0100

csiph-web