Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1552414
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch |
| Date | 2017-01-06 01:10 +0100 |
| Message-ID | <sWqgy-217-27@gated-at.bofh.it> (permalink) |
| References | <sW5lL-4mv-3@gated-at.bofh.it> <sWkkO-6b3-25@gated-at.bofh.it> <sWq6R-1FB-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 05, 2017 at 11:52:07PM +0000, Junichi Nomura wrote:
> >> + p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);
> >
> > Perhaps sizeof(*p) ?
>
> Yeah, that might be preferred.
No, those things are never preferred because
sizeof(struct <type>)
tells you exactly the size of what kind of object you're getting vs
sizeof(*p)
which tells you you're getting the size of what p points to.
Now you have to go look at p and what type it is. In the current case, p
is defined not far away from the use site but in a larger function, you
most likely need to eyeball up to its type when reading the code. Which
makes the whole thing less readable.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-05 02:50 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-05 11:30 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-05 18:50 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-06 01:00 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-06 01:10 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Junichi Nomura <j-nomura@ce.jp.nec.com> - 2017-01-06 01:20 +0100
Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch Borislav Petkov <bp@alien8.de> - 2017-01-06 12:00 +0100
[tip:x86/urgent] x86/microcode/intel: Fix allocation size of struct ucode_patch tip-bot for Junichi Nomura <tipbot@zytor.com> - 2017-01-09 23:20 +0100
csiph-web