Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1549612
| From | Tomasz Nowicki <tn@semihalf.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT |
| Date | 2017-01-03 09:50 +0100 |
| Message-ID | <sVsX7-3ui-5@gated-at.bofh.it> (permalink) |
| References | <sVb0d-7pH-3@gated-at.bofh.it> <sVb0e-7pH-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02.01.2017 14:31, Hanjun Guo wrote:
> For devices connecting to ITS, it needs dev id to identify
> itself, and this dev id is represented in the IORT table in
> named componant node [1] for platform devices, so in this
> patch we will scan the IORT to retrieve device's dev id.
>
> Introduce iort_pmsi_get_dev_id() with pointer dev passed
> in for that purpose.
>
> [1]: https://static.docs.arm.com/den0049/b/DEN0049B_IO_Remapping_Table.pdf
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Tested-by: Sinan Kaya <okaya@codeaurora.org>
> Tested-by: Majun <majun258@huawei.com>
> Tested-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Tomasz Nowicki <tn@semihalf.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
> drivers/acpi/arm64/iort.c | 26 ++++++++++++++++++++++++++
> drivers/irqchip/irq-gic-v3-its-platform-msi.c | 4 +++-
> include/linux/acpi_iort.h | 8 ++++++++
> 3 files changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 174e983..ab7bae7 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -444,6 +444,32 @@ u32 iort_msi_map_rid(struct device *dev, u32 req_id)
> }
>
> /**
> + * iort_pmsi_get_dev_id() - Get the device id for a device
> + * @dev: The device for which the mapping is to be done.
> + * @dev_id: The device ID found.
> + *
> + * Returns: 0 for successful find a dev id, errors otherwise
> + */
> +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id)
> +{
> + struct acpi_iort_node *node;
> +
> + if (!iort_table)
> + return -ENODEV;
> +
> + node = iort_find_dev_node(dev);
> + if (!node) {
> + dev_err(dev, "can't find related IORT node\n");
> + return -ENODEV;
> + }
> +
> + if(!iort_node_get_id(node, dev_id, IORT_MSI_TYPE, 0))
> + return -ENODEV;
> +
> + return 0;
> +}
> +
> +/**
Giving that you are extending this to NC->
SMMU->ITS case in later patch, we can use existing helpers from iort.c,
like that:
+/**
+ * iort_pmsi_get_dev_id() - Get the device id for a device
+ * @dev: The device for which the mapping is to be done.
+ * @dev_id: The device ID found.
+ *
+ * Returns: 0 for successful find a dev id, errors otherwise
+ */
+int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id)
+{
+ struct acpi_iort_node *node;
+
+ node = iort_find_dev_node(dev);
+ if (!node)
+ return -ENODEV;
+
+ if (!iort_node_map_rid(node, 0, dev_id, IORT_MSI_TYPE))
+ return -ENODEV;
+
+ return 0;
+}
Correct me if I am wrong.
Tomasz
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 00/14] ACPI platform MSI support and its example mbigen Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
[PATCH v6 04/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 04/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() Matthias Brugger <mbrugger@suse.com> - 2017-01-11 11:40 +0100
[PATCH v6 08/14] ACPI: ARM64: IORT: rework iort_node_get_id() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 08/14] ACPI: ARM64: IORT: rework iort_node_get_id() Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-04 19:00 +0100
Re: [PATCH v6 08/14] ACPI: ARM64: IORT: rework iort_node_get_id() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-05 09:30 +0100
[PATCH v6 09/14] ACPI: platform: setup MSI domain for ACPI based platform device Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 09/14] ACPI: platform: setup MSI domain for ACPI based platform device "Rafael J. Wysocki" <rafael@kernel.org> - 2017-01-02 22:20 +0100
[PATCH v6 13/14] irqchip: mbigen: introduce mbigen_of_create_domain() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
[PATCH v6 14/14] irqchip: mbigen: Add ACPI support Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
[PATCH v6 01/14] ACPI: ARM64: IORT: minor cleanup for iort_match_node_callback() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 01/14] ACPI: ARM64: IORT: minor cleanup for iort_match_node_callback() Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-03 15:10 +0100
Re: [PATCH v6 01/14] ACPI: ARM64: IORT: minor cleanup for iort_match_node_callback() Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 09:00 +0100
[PATCH v6 12/14] irqchip: mbigen: drop module owner Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
[PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Tomasz Nowicki <tn@semihalf.com> - 2017-01-03 09:50 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Tomasz Nowicki <tn@semihalf.com> - 2017-01-03 10:40 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Tomasz Nowicki <tn@semihalf.com> - 2017-01-03 12:30 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-04 20:20 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-05 13:50 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-05 16:20 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-01-10 16:00 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-11 15:20 +0100
Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-10 16:20 +0100
[PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Tomasz Nowicki <tn@semihalf.com> - 2017-01-03 08:50 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 08:10 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Tomasz Nowicki <tn@semihalf.com> - 2017-01-04 08:30 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 09:30 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Marc Zyngier <marc.zyngier@arm.com> - 2017-01-04 10:10 +0100
Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 11:30 +0100
[PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-11 11:30 +0100
Re: [PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order Matthias Brugger <mbrugger@suse.com> - 2017-01-11 11:30 +0100
Re: [PATCH v6 02/14] irqchip: gic-v3-its: keep the head file include in alphabetic order Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-11 15:20 +0100
[PATCH v6 07/14] irqchip: gicv3-its: platform-msi: scan MADT to create platform msi domain Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
[PATCH v6 10/14] ACPI: ARM64: IORT: rework iort_node_get_id() for NC->SMMU->ITS case Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-02 14:40 +0100
Re: [PATCH v6 10/14] ACPI: ARM64: IORT: rework iort_node_get_id() for NC->SMMU->ITS case Sinan Kaya <okaya@codeaurora.org> - 2017-01-02 23:40 +0100
Re: [PATCH v6 10/14] ACPI: ARM64: IORT: rework iort_node_get_id() for NC->SMMU->ITS case Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-03 01:20 +0100
csiph-web