Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI

From	Hanjun Guo <hanjun.guo@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI
Date	2017-01-04 09:30 +0100
Message-ID	<sVP7j-27Q-3@gated-at.bofh.it> (permalink)
References	<sVb0d-7pH-3@gated-at.bofh.it> <sVb0e-7pH-21@gated-at.bofh.it> <sVs13-2TD-1@gated-at.bofh.it> <sVNRT-1io-21@gated-at.bofh.it> <sVObf-1wo-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017/1/4 15:29, Tomasz Nowicki wrote:
> On 04.01.2017 08:02, Hanjun Guo wrote:
>> Hi Tomasz,
>>
>> On 2017/1/3 15:41, Tomasz Nowicki wrote:
>>> Hi,
>>>
>>> Can we merge patch 4 & 6 into one patch so that we keep refactoring part
>>> as one piece ? I do not see a reason to keep them separate or have patch
>>> 5 in between. You can refactor what needs to be refactored, add
>>> necessary functions to iort.c and then support ACPI for
>>> irq-gic-v3-its-platform-msi.c
>>
>> There are two functions here,
>>  - retrieve the dev id from IORT which was DT based only;
>>
>>  - init the platform msi domain from MADT;
>>
>> For each of them split it into two steps,
>>  - refactor the code for ACPI later and it's easy for review
>>    because wen can easily to figure out it has functional
>>    change or not
>>
>>  - add ACPI functionality
>>
>> Does it make sense?
>
> It is up to Marc, but personally I prefer:
> 1. Refactor dev id retrieving and init function in one patch and
> highlight no functional changes in changelog
> 2. Crate necessary infrastructure in iort.c
> 3. Then add ACPI support to irq-gic-v3-its-platform-msi.c

I have no strong preferences, and it's easy to do so as just
need to squash/reorder the patches.

Marc, Lorenzo, could you give some suggestions here?

Thanks
Hanjun

Thread

Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor  its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 08:10 +0100
  Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor  its_pmsi_init() to prepare for ACPI Tomasz Nowicki <tn@semihalf.com> - 2017-01-04 08:30 +0100
    Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor  its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 09:30 +0100
      Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor  its_pmsi_init() to prepare for ACPI Marc Zyngier <marc.zyngier@arm.com> - 2017-01-04 10:10 +0100
        Re: [PATCH v6 06/14] irqchip: gicv3-its: platform-msi: refactor  its_pmsi_init() to prepare for ACPI Hanjun Guo <hanjun.guo@linaro.org> - 2017-01-04 11:30 +0100

csiph-web