Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549603

[RFC] nodemask: Consider MAX_NUMNODES inside node_isset

Show all headers | View raw

node_isset can give incorrect result if the node number is beyond the
bitmask size (MAX_NUMNODES in this case) which is not checked inside
test_bit. Hence check for the bit limits (MAX_NUMNODES) inside the
node_isset function before calling test_bit.

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
 include/linux/nodemask.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h
index 6e66cfd..0aee588b 100644
--- a/include/linux/nodemask.h
+++ b/include/linux/nodemask.h
@@ -139,7 +139,13 @@ static inline void __nodes_clear(nodemask_t *dstp, unsigned int nbits)
 }
 
 /* No static inline type checking - see Subtlety (1) above. */
-#define node_isset(node, nodemask) test_bit((node), (nodemask).bits)
+#define node_isset(node, nodemask) node_test_bit(node, nodemask, MAX_NUMNODES)
+static inline int node_test_bit(int node, nodemask_t nodemask, int maxnodes)
+{
+	if (node >= maxnodes)
+		return 0;
+	return test_bit((node), (nodemask).bits);
+}
 
 #define node_test_and_set(node, nodemask) \
 			__node_test_and_set((node), &(nodemask))
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC] nodemask: Consider MAX_NUMNODES inside node_isset Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-01-03 09:30 +0100
  Re: [RFC] nodemask: Consider MAX_NUMNODES inside node_isset Michal Hocko <mhocko@kernel.org> - 2017-01-03 09:50 +0100
    Re: [RFC] nodemask: Consider MAX_NUMNODES inside node_isset Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-01-03 10:10 +0100
      Re: [RFC] nodemask: Consider MAX_NUMNODES inside node_isset Michal Hocko <mhocko@kernel.org> - 2017-01-03 10:20 +0100
        Re: [RFC] nodemask: Consider MAX_NUMNODES inside node_isset Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-01-03 10:50 +0100

csiph-web