[PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	[PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function
Date	2017-01-04 04:30 +0100
Message-ID	<sVKqZ-7ps-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Checking if there is no error followed by a goto if there is one is
confusing. Reverse the logic.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/watchdog/coh901327_wdt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
index a099b77fc0b9..dc97b2fd6c49 100644
--- a/drivers/watchdog/coh901327_wdt.c
+++ b/drivers/watchdog/coh901327_wdt.c
@@ -360,12 +360,10 @@ static int __init coh901327_probe(struct platform_device *pdev)
 
 	coh901327_wdt.parent = &pdev->dev;
 	ret = watchdog_register_device(&coh901327_wdt);
-	if (ret == 0)
-		dev_info(&pdev->dev,
-			 "initialized. timer margin=%d sec\n", margin);
-	else
+	if (ret)
 		goto out_no_wdog;
 
+	dev_info(&pdev->dev, "initialized. timer margin=%d sec\n", margin);
 	return 0;
 
 out_no_wdog:
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function Guenter Roeck <linux@roeck-us.net> - 2017-01-04 04:30 +0100
  Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in  probe function Linus Walleij <linus.walleij@linaro.org> - 2017-01-09 20:40 +0100
    Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in  probe function Guenter Roeck <linux@roeck-us.net> - 2017-01-09 21:20 +0100

csiph-web