Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1554679

Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function
Date 2017-01-09 21:20 +0100
Message-ID <sXOAa-gv-17@gated-at.bofh.it> (permalink)
References <sVKqZ-7ps-5@gated-at.bofh.it> <sXNXs-8fG-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 09, 2017 at 08:38:03PM +0100, Linus Walleij wrote:
> On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > Checking if there is no error followed by a goto if there is one is
> > confusing. Reverse the logic.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
Thanks!

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function Guenter Roeck <linux@roeck-us.net> - 2017-01-04 04:30 +0100
  Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in  probe function Linus Walleij <linus.walleij@linaro.org> - 2017-01-09 20:40 +0100
    Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in  probe function Guenter Roeck <linux@roeck-us.net> - 2017-01-09 21:20 +0100

csiph-web