Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1541103
| From | Ard Biesheuvel <ard.biesheuvel@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] firmware: dmi_scan: Always show system identification string |
| Date | 2016-12-13 15:30 +0100 |
| Message-ID | <sNWfD-2go-7@gated-at.bofh.it> (permalink) |
| References | <sMnjY-8qN-15@gated-at.bofh.it> <sMuOu-4x7-15@gated-at.bofh.it> <sNo4h-6w8-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12 December 2016 at 01:51, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>
> On 2016/12/9 22:55, Ard Biesheuvel wrote:
>> On 9 December 2016 at 06:54, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x
>>> and SMBIOS 3.x, and always show the system identification string,
>>> like Vendor, Product/Board name and BIOS infos.
>>>
>>
>> Are you saying the printk(KERN_DEBUG) was inconsistent with the
>> pr_debug() before?
>
> Yes, found it when check the boot dmesg on qemu, there is no print using pr_debug
> with defconfig on ARM64( smbios3 present), but could shown with printk(KERN_DEBUG.
>
That's interesting. I would assume pr_debug and printk(KERN_DEBUG) to
behave identically ...
>>
>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>> drivers/firmware/dmi_scan.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
>>> index 88bebe1..54be60e 100644
>>> --- a/drivers/firmware/dmi_scan.c
>>> +++ b/drivers/firmware/dmi_scan.c
>>> @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf)
>>> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
>>> }
>>> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
>>> - printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string);
>>> + pr_info("DMI: %s\n", dmi_ids_string);
>>> return 0;
>>> }
>>> }
>>> @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
>>> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF,
>>> dmi_ver & 0xFF);
>>> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
>>> - pr_debug("DMI: %s\n", dmi_ids_string);
>>> + pr_info("DMI: %s\n", dmi_ids_string);
>>> return 0;
>>> }
>>> }
>>> --
>>> 1.7.12.4
>>>
>>
>> .
>>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] firmware: dmi_scan: Always show system identification string Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-12-12 03:00 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-13 15:30 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-13 15:50 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Jean Delvare <jdelvare@suse.de> - 2016-12-13 15:50 +0100
csiph-web