Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1541103
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Ard Biesheuvel <ard.biesheuvel@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] firmware: dmi_scan: Always show system identification string |
| Date | Tue, 13 Dec 2016 15:30:01 +0100 |
| Message-ID | <sNWfD-2go-7@gated-at.bofh.it> (permalink) |
| References | <sMnjY-8qN-15@gated-at.bofh.it> <sMuOu-4x7-15@gated-at.bofh.it> <sNo4h-6w8-1@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HOExHFruFS/ZLzwtM0JIYHCHGfusdoOzWYEtTkFEh9U=; b=MwqhZIlsghXncOutmRL+iVGQioGnC+W0AjLnrkYy3cAjqSuTVJwXM865Y09gbTdaIA OXj9DJQHv9l2YCjvw1McNSKeze6VujIWH6dl60WSxYoTqhUdfv9vAcHhRsbEEriH3AhT 5w58bqhiu0aGDKXtghqyiuOBKmLipkcAVJFeY= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HOExHFruFS/ZLzwtM0JIYHCHGfusdoOzWYEtTkFEh9U=; b=K2uqAPBgVwqp/PzeaS0G/SNcqoF7uC6cT6j3B/k5BGdkHAQAZxLN6A5Vxn6MJ+9UOQ QK+/c1Mlsbas/6fTLNTBy0/48RqQZd7xXnaFu6xgCYYawKl43P2w7C/Bw5kTgkwKdZMN qQCKo2AYs0PZinkusDTIaEOQFEw1P2fmYSZu/j+AWmeJq+4rUCQYVvpo3RtkPW78S9ZX KtRTqEnUftEjvqG8wG5Na906oTrgBn6F6jahNQrkmY6dwZiXGy2+8rr4Ulrabm7TxkDq lmTRr9D+V6b772E6GI3KADLge4zQbF2KsFAoph0V0kReSBB5co2x5ntKl9axoh551Cf+ XpeA== |
| X-Gm-Message-State | AKaTC02pGCfXskJxKDbnfGGpR8FUrNZUsjyMJe+lSHf87Nrak/rim0e9lEXQV6jHWtExDgCId9WGJr405NxdvbDg |
| X-Received | by 10.107.2.8 with SMTP id 8mr77480298ioc.83.1481639105873; Tue, 13 Dec 2016 06:25:05 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 56 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Jean Delvare <jdelvare@suse.com>, Mark Rutland <mark.rutland@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Tue, 13 Dec 2016 14:25:05 +0000 |
| X-Original-Message-ID | <CAKv+Gu8HnH5mxxLvxNRqOm5vDYaU8ULX6kz=2RbbFqQ83Z5D0Q@mail.gmail.com> |
| X-Original-References | <1481266447-51471-1-git-send-email-wangkefeng.wang@huawei.com> <CAKv+Gu86rW34NozRHNNp13O0exoVL473kL8PFX-v114D8-u+_A@mail.gmail.com> <5d02bf23-fe10-53d3-f6b8-d7dc0400637e@huawei.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1541103 |
Show key headers only | View raw
On 12 December 2016 at 01:51, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>
> On 2016/12/9 22:55, Ard Biesheuvel wrote:
>> On 9 December 2016 at 06:54, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x
>>> and SMBIOS 3.x, and always show the system identification string,
>>> like Vendor, Product/Board name and BIOS infos.
>>>
>>
>> Are you saying the printk(KERN_DEBUG) was inconsistent with the
>> pr_debug() before?
>
> Yes, found it when check the boot dmesg on qemu, there is no print using pr_debug
> with defconfig on ARM64( smbios3 present), but could shown with printk(KERN_DEBUG.
>
That's interesting. I would assume pr_debug and printk(KERN_DEBUG) to
behave identically ...
>>
>>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>> drivers/firmware/dmi_scan.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
>>> index 88bebe1..54be60e 100644
>>> --- a/drivers/firmware/dmi_scan.c
>>> +++ b/drivers/firmware/dmi_scan.c
>>> @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf)
>>> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
>>> }
>>> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
>>> - printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string);
>>> + pr_info("DMI: %s\n", dmi_ids_string);
>>> return 0;
>>> }
>>> }
>>> @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
>>> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF,
>>> dmi_ver & 0xFF);
>>> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
>>> - pr_debug("DMI: %s\n", dmi_ids_string);
>>> + pr_info("DMI: %s\n", dmi_ids_string);
>>> return 0;
>>> }
>>> }
>>> --
>>> 1.7.12.4
>>>
>>
>> .
>>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] firmware: dmi_scan: Always show system identification string Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-12-12 03:00 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-13 15:30 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-13 15:50 +0100
Re: [PATCH] firmware: dmi_scan: Always show system identification string Jean Delvare <jdelvare@suse.de> - 2016-12-13 15:50 +0100
csiph-web