Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540766

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

Show all headers | View raw

On Dec 12, 2016, at 13:00, James Simmons <jsimmons@infradead.org> wrote:
> 
> 
>> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote:
>>> In order for lustre_idl.h to be usable for both user
>>> land and kernel space it has to use the proper
>>> byteorder functions.
>> 
>> Why would userspace need/want all of these inline functions?  A uapi
>> header file should just have a the structures that are passed
>> user/kernel and any needed ioctls.  Why would they ever care about
>> strange byte flip functions and a ton of inline functions?
>> 
>> I don't think this is needed, of if it is, I really don't want to see
>> your crazy userspace code...
> 
> Sigh. More cleanups were done based on the idea this was okay. The
> reason this was does was when you look at the headers in
> include/uapi/linux you see a huge number of headers containing a bunch
> of inline function. To an outside project looking to merge their work
> into the kernel they would think this is okay. Hopefully all those
> broken headers will be cleaned up in the near future.
> Alright I will look to fixing up our tools to handle this requirement. 

These accessor functions are used by both the kernel and userspace
tools, and keeping them in the lustre_idl.h header avoids duplication
of code.  Similar usage exists in other filesystem related uapi headers
(e.g. auto_fs4.h, bcache.h, btrfs_tree.h, nilfs2_ondisk.h, swab.h, etc.).

That said, if there is an objection to keeping these macros/inline funcs
in the uapi headers, they still need to exist in the kernel and should
be kept in the lustre/include/lustre directory and we'll keep a separate
copy of the macros for userspace.

Cheers, Andreas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-12 21:10 +0100
  Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-13 01:40 +0100
    Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-13 09:40 +0100
      Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h Oleg Drokin <oleg.drokin@intel.com> - 2016-12-13 17:20 +0100
        Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-13 18:30 +0100
  Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-12-13 02:00 +0100
    Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-13 02:10 +0100
      Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-19 18:10 +0100

csiph-web