Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1539880

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h
Date 2016-12-10 19:20 +0100
Message-ID <sMUpz-5Az-3@gated-at.bofh.it> (permalink)
References <sMUfT-5x2-3@gated-at.bofh.it> <sMUfT-5x2-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote:
> In order for lustre_idl.h to be usable for both user
> land and kernel space it has to use the proper
> byteorder functions.

Why would userspace need/want all of these inline functions?  A uapi
header file should just have a the structures that are passed
user/kernel and any needed ioctls.  Why would they ever care about
strange byte flip functions and a ton of inline functions?

I don't think this is needed, of if it is, I really don't want to see
your crazy userspace code...

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-10 19:10 +0100
  Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-10 19:20 +0100
    Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-12 21:10 +0100
      Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-13 01:40 +0100
        Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-13 09:40 +0100
          Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h Oleg Drokin <oleg.drokin@intel.com> - 2016-12-13 17:20 +0100
            Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-13 18:30 +0100
      Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-12-13 02:00 +0100
        Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-13 02:10 +0100
          Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder  functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-19 18:10 +0100

csiph-web