Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540630

Re: [PATCH 1/1] Fixed to codestyle

Show all headers | View raw

On 12/12/16 2:34 PM, Ozgur Karatas wrote:
> 12.12.2016, 20:35, "Eric Sandeen" <sandeen@sandeen.net>:
>> On 12/12/16 12:14 PM, Joe Perches wrote:

...

>>>>>   {
>>>>>           xfs_uu_t *uup = (xfs_uu_t *)uuid;
>>>>>
>>>>>  @@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid)
>>>>>           if (uuid == NULL)
>>>>>                   return 0;
>>>>>           /* implied check of version number here... */
>>>>>  - for (i = 0; i < sizeof *uuid; i++)
>>>>>  - if (*cp++) return 0; /* not nil */
>>>>>  + for (i = 0; i < sizeof (*uuid); i++)
>>>>>  + if (*cp++) return 0; /* not nil */
>>>
>>>  There shouldn't be a space after sizeof.
>>
>> and the "if" /should/ be indented under the for loop, because
>> it is within the loop...
>>
>> I suppose simply:
>>
>> - for (i = 0; i < sizeof *uuid; i++)
>> + for (i = 0; i < sizeof(*uuid); i++)
>>
>> would be fine on its own, though, because that is a bit
>> unusual/inconsistent. I'll admit that I didn't spot
>> that change as I scanned over the unnecessary & incorrect parts
>> of the first patch. :)
>>
>> thanks,
>> -Eric
> 
> Dear Eric;
> 
> Can you tell me the true code style? should use to (* uuid)? 
> I'm learn to new and I'm newbies :)

Well, rule #1 for newbies is "code style patches aren't
very useful, and usually are not welcomed by the project."

Making style changes just because checkpatch told you to is
not particularly helpful.  If it were important, it would have
been done by now.  If it hasn't been done by now, odds are
it's not important.  :)

If you are writing /new/ code, then sure, conform to the kernel
style, /aided/ by checkpatch.pl, and using your discretion as
well.

If you are just now looking at xfs/* code, best not to start
with "style" cleanups.  You'll find this to be true in general
across the kernel, maintainers are usually not thrilled to have
this kind of patch.

If you want to start with a new project, learn about the code,
learn what it /does/, learn how to use it.  use it.  Find things
that don't work as expected, or could work better.  Look into
bug reports and if you understand them, and the code involved,
try to write and test a fix.  But don't go looking for whitespace
nitpicks.

> Sorry,

No need to be sorry, this is how we learn.  ;)  But really, making
purely cosmetic changes for their own sake is not helpful in
general.

-Eric

> Regards
> 
> Ozgur
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] Fixed to codestyle Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-12 12:10 +0100
  Re: [PATCH 1/1] Fixed to codestyle Eric Sandeen <sandeen@sandeen.net> - 2016-12-12 14:50 +0100
    Re: [PATCH 1/1] Fixed to codestyle Joe Perches <joe@perches.com> - 2016-12-12 19:20 +0100
      Re: [PATCH 1/1] Fixed to codestyle Eric Sandeen <sandeen@sandeen.net> - 2016-12-12 19:40 +0100
        Re: [PATCH 1/1] Fixed to codestyle Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-12 21:40 +0100
          Re: [PATCH 1/1] Fixed to codestyle Eric Sandeen <sandeen@sandeen.net> - 2016-12-12 21:50 +0100
            Re: [PATCH 1/1] Fixed to codestyle Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-12 21:50 +0100
            Re: [PATCH 1/1] Fixed to codestyle Joe Perches <joe@perches.com> - 2016-12-12 22:00 +0100
              Re: [PATCH 1/1] Fixed to codestyle Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-12 22:00 +0100
              Re: [PATCH 1/1] Fixed to codestyle Eric Sandeen <sandeen@sandeen.net> - 2016-12-12 22:20 +0100
      Re: [PATCH 1/1] Fixed to codestyle Ozgur Karatas <okaratas@member.fsf.org> - 2016-12-12 21:40 +0100

csiph-web