Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

From	Michal Marek <mmarek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory
Date	2016-12-12 21:50 +0100
Message-ID	<sNFHP-v6-9@gated-at.bofh.it> (permalink)
References	<stmRr-8w6-15@gated-at.bofh.it> <sLmJk-1Qg-19@gated-at.bofh.it> <sNjR0-49m-13@gated-at.bofh.it> <sNCqB-75R-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dne 12.12.2016 v 18:13 Robert Jarzmik napsal(a):
> Michal Marek <mmarek@suse.com> writes:
>> Please use the KBUILD_OUTPUT variable and not O.
> Well, I can't as far as I know. I tried, see below ...
> 
> Explanation :
>  - if I add just below the line "j=${i/\.[cS]/\.o}" the following :
> 	k="$O/${j#$tree}"
>         echo "tree=$tree; O=$O; KBUILD_OUTPUT=$KBUILD_OUTPUT; i=$i, j=$j, k=$k"
>  - and I launch:
> 	make O=out cscope COMPILED_SOURCE=1
>  
> I get these kind of lines :
> tree=../; O=/home/rj/mio_linux/kernel/out; KBUILD_OUTPUT=;
> i=../kernel/sched/core.c, j=../kernel/sched/core.o, k=../kernel/sched/core.o
> 
> From here I understand that :
>  - $KBUILD_OUTPUT is not usable

Hm, you are right, we never export $KBUILD_OUTPUT anywhere. But, we
actualy chdir into the build tree before doing anything. So you can
assume that if $KBUILD_SRC != "", the build tree is ".".


>> should only match at the beginning of the filename (so use something
>> like ${i#$tree}).
> Ok, I can use then : k="$O/${j#$tree}". The subtle part is when O is empty, in
> which case this returns /xxxx, which doesn't look nice, while the former
> expression returned either a substituted path or the source path.

... so you can simply strip the leading $tree here and obtain the path
in the build directory.

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory Michal Marek <mmarek@suse.com> - 2016-12-11 22:30 +0100
  Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory Robert Jarzmik <robert.jarzmik@free.fr> - 2016-12-12 18:20 +0100
    Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory Michal Marek <mmarek@suse.com> - 2016-12-12 21:50 +0100

csiph-web