Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538595

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

From Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready
Date 2016-12-08 16:00 +0100
Message-ID <sM8kW-7mt-29@gated-at.bofh.it> (permalink)
References <sHwee-5RF-11@gated-at.bofh.it> <sJPmq-8jy-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/02/2016 01:15 AM, Juergen Gross wrote:
> Instead of requesting a new slot on the ring to the backend early, do
> so only after all has been setup for the request to be sent. This
> makes error handling easier as we don't need to undo the request id
> allocation and ring slot allocation.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

(although it would be good to have someone familiar with this code look 
at this as well).

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] xen-scsifront: Add a missing call to kfree Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-25 22:30 +0100
  [PATCH] xen/scsifront: don't advance ring request pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:00 +0100
    Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring  request pointer in case of error "Jan Beulich" <JBeulich@suse.com> - 2016-11-29 12:20 +0100
    Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:20 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error David Vrabel <david.vrabel@citrix.com> - 2016-11-29 12:40 +0100
        Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 12:40 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring  request pointer in case of error "Jan Beulich" <JBeulich@suse.com> - 2016-11-29 12:50 +0100
      Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request  pointer in case of error Juergen Gross <jgross@suse.com> - 2016-11-29 13:40 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
  [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready Juergen Gross <jgross@suse.com> - 2016-12-02 07:20 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Juergen Gross <jgross@suse.com> - 2016-12-05 16:40 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-05 16:40 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-12-08 16:00 +0100
    Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until  request is ready Juergen Gross <jgross@suse.com> - 2016-12-09 11:20 +0100

csiph-web