Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support
Date	2016-12-06 01:00 +0100
Message-ID	<sLbkS-2IL-29@gated-at.bofh.it> (permalink)
References	<sJomd-5rJ-3@gated-at.bofh.it> <sLbbb-2Fq-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Rob,

On Mon, Dec 05, 2016 at 05:42:48PM -0600, Rob Herring wrote:
> On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote:
> > From: Caesar Wang <wxt@rock-chips.com>
> > 
> > Add a compatible string and regulator property for Wacom W9103
> > digitizer. Its VDD supply may need to be enabled before using it.
> > 
> > Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Jiri Kosina <jikos@kernel.org>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > ---
> > v1 was a few months back. I finally got around to rewriting it based on
> > DT binding feedback.
> > 
> > v2:
> >  * add compatible property for wacom
> >  * name the regulator property specifically (VDD)
> > 
> >  Documentation/devicetree/bindings/input/hid-over-i2c.txt | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks but (unfortunately) there've been 2 new versions since then.
Specifically, Benjamin NACK'ed this patch and requested we NOT include
device/manufacturer-specific compatible properties here. In fact, the
binding is still rather generic and IMO (and in Benjamin's opinion)
doesn't really need to be restricted to a specific device.

Please consider reviewing Benjamin's requests and my recent changes.
Benjamin has one small remaining comment on v4, and I plan to send the
5th (and final?) version once I'm confident you and Benjamin agree :)

Thanks,
Brian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris <briannorris@chromium.org> - 2016-12-01 02:30 +0100
  [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Brian Norris <briannorris@chromium.org> - 2016-12-01 02:30 +0100
    Re: [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-01 15:50 +0100
      Re: [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Brian Norris <briannorris@chromium.org> - 2016-12-01 18:40 +0100
  Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-01 15:40 +0100
    Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Brian Norris <briannorris@chromium.org> - 2016-12-01 18:30 +0100
      Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-06 01:00 +0100
        Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-06 01:40 +0100
        Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-06 09:50 +0100
          Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-06 16:00 +0100
            Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Doug Anderson <dianders@chromium.org> - 2016-12-06 17:20 +0100
              Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-08 16:50 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:10 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-08 17:20 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:30 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-08 19:20 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-09 15:40 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Jiri Kosina <jikos@kernel.org> - 2016-12-09 15:40 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-09 16:10 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Doug Anderson <dianders@chromium.org> - 2016-12-09 17:20 +0100
              Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:10 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Doug Anderson <dianders@chromium.org> - 2016-12-09 17:10 +0100
                Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-09 18:50 +0100
  Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Rob Herring <robh@kernel.org> - 2016-12-06 00:50 +0100
    Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer +  regulator support Brian Norris <briannorris@chromium.org> - 2016-12-06 01:00 +0100

csiph-web