RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

From	"Gonglei (Arei)" <arei.gonglei@huawei.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v5 1/1] crypto: add virtio-crypto driver
Date	2016-12-08 03:20 +0100
Message-ID	<sLWtr-8ph-15@gated-at.bofh.it> (permalink)
References	<sJz7Y-3YF-21@gated-at.bofh.it> <sKv2h-1iQ-9@gated-at.bofh.it> <sKRYS-7qO-13@gated-at.bofh.it> <sLRap-4Se-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sam,

>
> Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver
> 
> On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote:
> > I don't think the root cause of those warnings are introduced by virtio-crypto
> driver.
> >
> > What's your opinion? Sam and David?
> 
> Root cause here is that arch/sparc/include/asm/topology_64.h
> references cpu_data without including arch/sparc/include/asm/cpudata.h
> 
> I think other architectures pull in the dependency from
> either smp.h or they have it topology.h.
> 
> The easy fix would be to include cpudata.h in
> arch/sparc/include/asm/topology_64.h.
> And that should also be a correct fix.
> 
> Could you include this in your patch-set and build test it?
> 
Sure, I can add this one at the head of my patch set, but because I
haven't sparc environment, so it depends on the kbuild test robot
to test.

Thanks,
-Gonglei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-05 04:20 +0100
  Re: [PATCH v5 1/1] crypto: add virtio-crypto driver Sam Ravnborg <sam@ravnborg.org> - 2016-12-07 21:40 +0100
    RE: [PATCH v5 1/1] crypto: add virtio-crypto driver "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-08 03:20 +0100

csiph-web