[PATCH 1/1] net: caif: fix ineffective error check

From	Pan Bian <bianpan2016@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] net: caif: fix ineffective error check
Date	2016-12-03 12:40 +0100
Message-ID	<sKgPD-wb-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In function caif_sktinit_module(), the check of the return value of
sock_register() seems ineffective. This patch fixes it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/caif/caif_socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
index aa209b1..2a689a3 100644
--- a/net/caif/caif_socket.c
+++ b/net/caif/caif_socket.c
@@ -1108,7 +1108,7 @@ static int caif_create(struct net *net, struct socket *sock, int protocol,
 static int __init caif_sktinit_module(void)
 {
 	int err = sock_register(&caif_family_ops);
-	if (!err)
+	if (err)
 		return err;
 	return 0;
 }
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: caif: fix ineffective error check Pan Bian <bianpan2016@163.com> - 2016-12-03 12:40 +0100
  Re: [PATCH 1/1] net: caif: fix ineffective error check Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-03 14:20 +0100
    Re: [PATCH 1/1] net: caif: fix ineffective error check Pan Bian <bianpan201602@163.com> - 2016-12-03 17:30 +0100
      Re: [PATCH 1/1] net: caif: fix ineffective error check Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-03 22:10 +0100

csiph-web