Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1535380

[PATCH 1/1] net: caif: fix ineffective error check

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Pan Bian <bianpan2016@163.com>
Newsgroups linux.kernel
Subject [PATCH 1/1] net: caif: fix ineffective error check
Date Sat, 03 Dec 2016 12:40:01 +0100
Message-ID <sKgPD-wb-1@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=76OxYTdEiPTS+vxOt7 n0VbI8s3zNHKbQNPPTgDvX+6U=; b=QsFpWbm76h6GU0YYHJEJ1Gr2EeGFUi82vz TFzeBEikviBr8CZYgf1OCp1xfly6ZJbuTaJipUz2+RC+aE9qVdlXOfFV8QWHWIAd ZKMQnOZv0i3uuT9w3SQJfRA+5sDaMtqnc1o2G2NJYn5erGP5SbngF5+P2Z/JZ81p 7I4p/Tu34=
X-Mailer git-send-email 1.9.1
X-Cm-Transid DNGowABnDPH8qUJYVDoQIQ--.63492S3
X-Coremail-Antispam 1Uf129KBjvdXoWrZr4kCw17uFyDAw13tryfCrg_yoW3Xrb_Cr yUJa1UK3Wktr4Fk3y5C398XF9Ygrs5XFsaqr47Ja42gw1xWryYvrs7CF9xAF1rWryIkryU Wrn5JF9Iqw47ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUn6OJ7UUUUU==
X-Originating-IP [222.131.246.88]
X-Cm-Senderinfo held01tdqsiiqw6rljoofrz/1tbiDgA1clXlhmgeWQAAsQ
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 25
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com>
X-Original-Date Sat, 3 Dec 2016 19:18:21 +0800
X-Original-Message-ID <1480763901-5323-1-git-send-email-bianpan2016@163.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1535380

Show key headers only | View raw


In function caif_sktinit_module(), the check of the return value of
sock_register() seems ineffective. This patch fixes it.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/caif/caif_socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
index aa209b1..2a689a3 100644
--- a/net/caif/caif_socket.c
+++ b/net/caif/caif_socket.c
@@ -1108,7 +1108,7 @@ static int caif_create(struct net *net, struct socket *sock, int protocol,
 static int __init caif_sktinit_module(void)
 {
 	int err = sock_register(&caif_family_ops);
-	if (!err)
+	if (err)
 		return err;
 	return 0;
 }
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] net: caif: fix ineffective error check Pan Bian <bianpan2016@163.com> - 2016-12-03 12:40 +0100
  Re: [PATCH 1/1] net: caif: fix ineffective error check Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-03 14:20 +0100
    Re: [PATCH 1/1] net: caif: fix ineffective error check Pan Bian <bianpan201602@163.com> - 2016-12-03 17:30 +0100
      Re: [PATCH 1/1] net: caif: fix ineffective error check Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-12-03 22:10 +0100

csiph-web