Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533297

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

Show all headers | View raw

On 11/27/2016 11:51 AM, Jonathan Cameron wrote:
> On 26/11/16 03:47, Aniroop Mathur wrote:
>> msleep(1~20) may not do what the caller intends, and will often sleep longer.
>> (~20 ms actual sleep for any value given in the 1~20ms range)
>> This is not the desired behaviour for many cases like device resume time,
>> device suspend time, device enable time, data reading time, etc.
>> Thus, change msleep to usleep_range for precise wakeups.
>>
>> Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
> As these need individual review by the various original authors and driver maintainers to
> establish the intent of the sleep, it would have been better to have done a series of
> patches (one per driver) with the relevant maintainers cc'd on the ones that they care about.
> 
> Most of these are ADI parts looked after by Lars though so perhaps wait for his comments
> before respining.

I agree with what Jonathan said. For most of these extending the maximum
sleep time a bit further is ok.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <a.mathur@samsung.com> - 2016-11-26 04:40 +0100
  Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Jonathan Cameron <jic23@kernel.org> - 2016-11-27 12:00 +0100
    Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Linus Walleij <linus.walleij@linaro.org> - 2016-11-30 13:20 +0100
      Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-02 20:10 +0100
    Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Lars-Peter Clausen <lars@metafoo.de> - 2016-11-30 14:40 +0100
    RE: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <a.mathur@samsung.com> - 2016-11-30 15:50 +0100
      Re: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-02 20:10 +0100
        Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Jonathan Cameron <jic23@kernel.org> - 2016-12-03 15:40 +0100
          Re: [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur <aniroop.mathur@gmail.com> - 2016-12-03 16:50 +0100

csiph-web