Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1527930
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources |
| Date | 2016-11-22 22:10 +0100 |
| Message-ID | <sGque-45L-43@gated-at.bofh.it> (permalink) |
| References | <sFWFP-1DY-1@gated-at.bofh.it> <sGlEe-BN-19@gated-at.bofh.it> <sGlEe-BN-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday, November 22, 2016 4:00:13 PM CET Lee Jones wrote: > > > diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h > > > index cafb9e6..0293fdd 100644 > > > --- a/include/dt-bindings/mfd/tps65217.h > > > +++ b/include/dt-bindings/mfd/tps65217.h > > > @@ -19,8 +19,8 @@ > > > #ifndef __DT_BINDINGS_TPS65217_H__ > > > #define __DT_BINDINGS_TPS65217_H__ > > > > > > -#define TPS65217_IRQ_USB 0 > > > -#define TPS65217_IRQ_AC 1 > > > -#define TPS65217_IRQ_PB 2 > > > +#define TPS65217_IRQ_USB_POWER 0 /* USB power state change */ > > > +#define TPS65217_IRQ_AC_POWER 1 /* AC power state change */ > > > +#define TPS65217_IRQ_PUSHBUTTON 2 /* Push button state change */ > > > > This changes the ABI. > > > > It will require a DT Ack. > > Tell a lie. Sorry, I was getting false positives from my grep. It > looks like you use the same scheme from within include/linux. I > suggest that you probable don't want to do that. Doing this change however would cause a bisection problem: you can't rename just the constants in the header or just the driver using those constants. Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-21 14:20 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Lee Jones <lee.jones@linaro.org> - 2016-11-22 17:00 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Arnd Bergmann <arnd@arndb.de> - 2016-11-22 22:10 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Lee Jones <lee.jones@linaro.org> - 2016-11-22 17:00 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-23 12:40 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Arnd Bergmann <arnd@arndb.de> - 2016-11-23 13:00 +0100
Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Milo Kim <woogyom.kim@gmail.com> - 2016-11-23 14:10 +0100
csiph-web