Re: [PATCHv11 2/3] usb: USB Type-C connector class

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv11 2/3] usb: USB Type-C connector class
Date	2016-11-22 09:20 +0100
Message-ID	<sGet4-4Fo-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <sEsAb-838-53@gated-at.bofh.it> <sFUaZ-8sg-17@gated-at.bofh.it> <sFWZc-1K0-13@gated-at.bofh.it> <sFY4V-2qO-1@gated-at.bofh.it> <sGejn-4AC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 22, 2016 at 09:58:13AM +0200, Heikki Krogerus wrote:
> Hi Greg,
> 
> On Mon, Nov 21, 2016 at 03:46:08PM +0100, Greg KH wrote:
> > > > > +
> > > > > +config TYPEC
> > > > > +	tristate
> > > > 
> > > > Hah, that says NOTHING about what this code is at all.
> > > 
> > > Alone the class driver does nothing. Why would the user need to be
> > > aware of if it when selecting the Type-C drivers, and what can the
> > > user use that information for?
> > 
> > If you see a blank Kconfig option, what are you supposed to do with it?
> > How do you know if you need to enable it or not?  Are you just supposed
> > to guess?
> 
> But you don't see anything when you are selecting the drivers and that
> is the point. You now can't select this separately. There is now no
> option for it.
> 
> Why should we bother the user with this? The user is most likely only
> interested in the drivers and by selecting those the user will get the
> interface. The drivers will need to have the dependency to the class
> set correctly in any case.

So with this patch, no code gets built or asked about in Kconfig?

Odd, if so, sorry for the noise...

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv11 0/3] USB Type-C Connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  [PATCHv11 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  [PATCHv11 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:40 +0100
    Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 14:20 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 15:30 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-11-21 16:40 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 10:00 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 15:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 12:00 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 14:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 14:50 +0100
  Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:40 +0100
    Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 14:40 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 15:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 09:10 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-22 09:20 +0100

csiph-web