Re: [PATCHv11 2/3] usb: USB Type-C connector class

From	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv11 2/3] usb: USB Type-C connector class
Date	2016-11-21 15:30 +0100
Message-ID	<sFXLz-2km-7@gated-at.bofh.it> (permalink)
References	<sEsAa-838-11@gated-at.bofh.it> <sEsAb-838-53@gated-at.bofh.it> <sFUaZ-8sg-11@gated-at.bofh.it> <sFWFQ-1DY-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote:
> Hi Greg,
> 
> On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote:
> > > +static void typec_partner_release(struct device *dev)
> > > +{
> > > +	struct typec_port *port = to_typec_port(dev->parent);
> > > +
> > > +	typec_unregister_altmodes(dev);
> > > +	port->partner = NULL;
> > > +}
> > 
> > This doesn't feel right, why are you both exporting
> > typec_unregister_altmodes() and also calling it from release callbacks?
> > That implies there is two way to clean stuff up, so what is a driver
> > writer to use?  Please simplify and force it to be one way or the other.
> 
> OK.

Guenter did you need to also remove the alternate modes in drivers, or
can we just do it here?

Thanks,

-- 
heikki

Thread

[PATCHv11 0/3] USB Type-C Connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  [PATCHv11 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  [PATCHv11 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-17 12:00 +0100
  Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:40 +0100
    Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 14:20 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 15:30 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-11-21 16:40 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 10:00 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 15:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 12:00 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 14:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 14:50 +0100
  Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 11:40 +0100
    Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-21 14:40 +0100
      Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-21 15:50 +0100
        Re: [PATCHv11 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-22 09:10 +0100
          Re: [PATCHv11 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-22 09:20 +0100

csiph-web