Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1528546

Re: [PATCH v2 0/4] tpm: kdoc cleanup

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 0/4] tpm: kdoc cleanup
Date 2016-11-23 17:10 +0100
Message-ID <sGIhs-71P-33@gated-at.bofh.it> (permalink)
References <sGBIZ-2TX-5@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Wed, Nov 23, 2016 at 12:04:10PM +0200, Tomas Winkler wrote:
> Cleanup tpm in-code documentation.
> 
> Tomas Winkler (4):
>   tpm: add kdoc for tpm_transmit and tpm_transmit_cmd
>   tpm/tpm2-chip: fix kdoc errors
>   tmp: use pdev for parent device in tpm_chip_alloc
>   tpm/vtpm: fix kdoc warnings

Thanks. Overally LGTM but I have to postpone the review till' next week.

/Jarkko

> 
>  drivers/char/tpm/tpm-chip.c       |   8 +--
>  drivers/char/tpm/tpm-interface.c  |  33 ++++++++++--
>  drivers/char/tpm/tpm2-cmd.c       | 105 +++++++++++++++++++++-----------------
>  drivers/char/tpm/tpm_ibmvtpm.c    |  51 +++++++++---------
>  drivers/char/tpm/tpm_vtpm_proxy.c |  48 ++++++++++++-----
>  5 files changed, 150 insertions(+), 95 deletions(-)
> 
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/4] tpm: kdoc cleanup Tomas Winkler <tomas.winkler@intel.com> - 2016-11-23 10:10 +0100
  [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Tomas Winkler <tomas.winkler@intel.com> - 2016-11-23 10:10 +0100
  [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc Tomas Winkler <tomas.winkler@intel.com> - 2016-11-23 10:10 +0100
  [PATCH v2 4/4] tpm/vtpm: fix kdoc warnings Tomas Winkler <tomas.winkler@intel.com> - 2016-11-23 10:10 +0100
  [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors Tomas Winkler <tomas.winkler@intel.com> - 2016-11-23 10:20 +0100
  Re: [PATCH v2 0/4] tpm: kdoc cleanup Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-23 17:10 +0100
  Re: [PATCH v2 0/4] tpm: kdoc cleanup Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-24 14:20 +0100

csiph-web