Groups > linux.kernel > #1520033

Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload
Date	2016-11-11 22:20 +0100
Message-ID	<sCroS-1fb-35@gated-at.bofh.it> (permalink)
References	<sscAN-33Q-11@gated-at.bofh.it> <ssdZY-3Nv-17@gated-at.bofh.it> <sCpZL-9R-1@gated-at.bofh.it> <sCpZL-9R-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Guenter,

On 11/11/2016 04:47 PM, Guenter Roeck wrote:
> Hi Javier,
> 
> On Fri, Nov 11, 2016 at 04:43:37PM -0300, Javier Martinez Canillas wrote:
>> Hello Guenter,
>>
>> On 10/14/2016 01:55 PM, Guenter Roeck wrote:
>>> On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote:
>>>> If the driver is built as a module, autoload won't work because the module
>>>> alias information is not filled. So user-space can't match the registered
>>>> device with the corresponding module.
>>>>
>>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>>
>>>> Before this patch:
>>>>
>>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
>>>> $
>>>>
>>>> After this patch:
>>>>
>>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
>>>> alias:          of:N*T*Cbrcm,bcm7038-wdtC*
>>>> alias:          of:N*T*Cbrcm,bcm7038-wdt
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>
>> Are you going to pick this (and patch 2/2)?
>>
>> I'm asking because you provided your r-b tag but the patch
>> was never merged, so I wonder who should I ping about it.
>>
> Wim would be the one to pick it.
> 
> Maybe it got lost.  I hope I'll find some time during the weekend
> to update my tracking branch.
> 

Ok, thanks a lot for the info.

> Guenter
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-11 20:50 +0100
  Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Guenter Roeck <linux@roeck-us.net> - 2016-11-11 20:50 +0100
    Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-11 22:20 +0100

csiph-web