Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1519993 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2016-11-11 20:50 +0100 |
| Last post | 2016-11-11 22:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-11 20:50 +0100
Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Guenter Roeck <linux@roeck-us.net> - 2016-11-11 20:50 +0100
Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-11 22:20 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-11-11 20:50 +0100 |
| Subject | Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload |
| Message-ID | <sCpZL-9R-1@gated-at.bofh.it> |
Hello Guenter, On 10/14/2016 01:55 PM, Guenter Roeck wrote: > On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote: >> If the driver is built as a module, autoload won't work because the module >> alias information is not filled. So user-space can't match the registered >> device with the corresponding module. >> >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >> >> Before this patch: >> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >> $ >> >> After this patch: >> >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >> alias: of:N*T*Cbrcm,bcm7038-wdtC* >> alias: of:N*T*Cbrcm,bcm7038-wdt >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > Are you going to pick this (and patch 2/2)? I'm asking because you provided your r-b tag but the patch was never merged, so I wonder who should I ping about it. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-11-11 20:50 +0100 |
| Message-ID | <sCpZL-9R-3@gated-at.bofh.it> |
| In reply to | #1519993 |
Hi Javier, On Fri, Nov 11, 2016 at 04:43:37PM -0300, Javier Martinez Canillas wrote: > Hello Guenter, > > On 10/14/2016 01:55 PM, Guenter Roeck wrote: > > On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote: > >> If the driver is built as a module, autoload won't work because the module > >> alias information is not filled. So user-space can't match the registered > >> device with the corresponding module. > >> > >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. > >> > >> Before this patch: > >> > >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias > >> $ > >> > >> After this patch: > >> > >> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias > >> alias: of:N*T*Cbrcm,bcm7038-wdtC* > >> alias: of:N*T*Cbrcm,bcm7038-wdt > >> > >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > > Are you going to pick this (and patch 2/2)? > > I'm asking because you provided your r-b tag but the patch > was never merged, so I wonder who should I ping about it. > Wim would be the one to pick it. Maybe it got lost. I hope I'll find some time during the weekend to update my tracking branch. Guenter
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2016-11-11 22:20 +0100 |
| Message-ID | <sCroS-1fb-35@gated-at.bofh.it> |
| In reply to | #1519994 |
Hello Guenter, On 11/11/2016 04:47 PM, Guenter Roeck wrote: > Hi Javier, > > On Fri, Nov 11, 2016 at 04:43:37PM -0300, Javier Martinez Canillas wrote: >> Hello Guenter, >> >> On 10/14/2016 01:55 PM, Guenter Roeck wrote: >>> On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote: >>>> If the driver is built as a module, autoload won't work because the module >>>> alias information is not filled. So user-space can't match the registered >>>> device with the corresponding module. >>>> >>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro. >>>> >>>> Before this patch: >>>> >>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >>>> $ >>>> >>>> After this patch: >>>> >>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias >>>> alias: of:N*T*Cbrcm,bcm7038-wdtC* >>>> alias: of:N*T*Cbrcm,bcm7038-wdt >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >>> >> >> Are you going to pick this (and patch 2/2)? >> >> I'm asking because you provided your r-b tag but the patch >> was never merged, so I wonder who should I ping about it. >> > Wim would be the one to pick it. > > Maybe it got lost. I hope I'll find some time during the weekend > to update my tracking branch. > Ok, thanks a lot for the info. > Guenter > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web