Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1519289

Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

Show all headers | View raw

On Wed, Nov 9, 2016 at 8:55 PM, Chen Yu <yu.c.chen@intel.com> wrote:
> Previously we encountered some memory overflow issues due to
> the bogus sleep time brought by inconsistent rtc, which is
> triggered when pm_trace is enabled, and we have fixed it
> in recent kernel. However it's improper in the first place
> to call __timekeeping_inject_sleeptime() in case that pm_trace
> is enabled simply because that "hash" time value will wreckage
> the timekeeping subsystem.
>
> This patch is originally written by Thomas, which would bypass
> the bogus rtc interval when pm_trace is enabled.
> Meanwhile, if system succeed to resume back with pm_trace set, the
> users are warned to adjust the bogus rtc either by ntp-date or rdate,
> by resetting pm_trace_rtc_abused to false, otherwise above tools might
> not work as expected.
>
> Originally-from: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Xunlei Pang <xlpang@redhat.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>


Looks ok to me. I'm queueing it up for testing.  If no one objects
(and I don't see any issues) I'll merge it to my tree and push it to
-tip through Thomas.

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Chen Yu <yu.c.chen@intel.com> - 2016-11-10 05:50 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled Pavel Machek <pavel@ucw.cz> - 2016-11-10 17:40 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled Thomas Gleixner <tglx@linutronix.de> - 2016-11-10 18:30 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled John Stultz <john.stultz@linaro.org> - 2016-11-10 19:30 +0100
    Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-11 02:30 +0100

csiph-web