Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1519124

Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled
Date 2016-11-10 17:40 +0100
Message-ID <sC0ym-dI-17@gated-at.bofh.it> (permalink)
References <sBPtf-Hr-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu 2016-11-10 12:55:53, Chen Yu wrote:
> Previously we encountered some memory overflow issues due to
> the bogus sleep time brought by inconsistent rtc, which is
> triggered when pm_trace is enabled, and we have fixed it
> in recent kernel. However it's improper in the first place
> to call __timekeeping_inject_sleeptime() in case that pm_trace
> is enabled simply because that "hash" time value will wreckage
> the timekeeping subsystem.
> 
> This patch is originally written by Thomas, which would bypass
> the bogus rtc interval when pm_trace is enabled.
> Meanwhile, if system succeed to resume back with pm_trace set, the
> users are warned to adjust the bogus rtc either by ntp-date or rdate,
> by resetting pm_trace_rtc_abused to false, otherwise above tools might
> not work as expected.
> 
> Originally-from: Thomas Gleixner <tglx@linutronix.de>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Xunlei Pang <xlpang@redhat.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "H. Peter Anvin" <hpa@zytor.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled Chen Yu <yu.c.chen@intel.com> - 2016-11-10 05:50 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled Pavel Machek <pavel@ucw.cz> - 2016-11-10 17:40 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled Thomas Gleixner <tglx@linutronix.de> - 2016-11-10 18:30 +0100
  Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if  pm_trace is enabled John Stultz <john.stultz@linaro.org> - 2016-11-10 19:30 +0100
    Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-11 02:30 +0100

csiph-web