Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1517571

Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP
Date 2016-11-08 21:50 +0100
Message-ID <sBlvb-5XM-19@gated-at.bofh.it> (permalink)
References (1 earlier) <sA934-8lK-9@gated-at.bofh.it> <sAWdr-6oY-17@gated-at.bofh.it> <sAWwO-6Ln-43@gated-at.bofh.it> <sAWZQ-6Y4-25@gated-at.bofh.it> <sBj0m-4ko-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 8 Nov 2016, Borislav Petkov wrote:
> 
> Also, this fixes another bug where machine_check_poll() would clear
> mce.tsc unconditionally even if we requested precise MCP_TIMESTAMP
> logging.

> @@ -713,7 +713,6 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
>  		m.misc = 0;
>  		m.addr = 0;
>  		m.bank = i;
> -		m.tsc = 0;

That does not make any sense. Where is m.tsc initialized? I couldn't find
any place which does, except this and the conditional clear farther down in
that function.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no consumers Borislav Petkov <bp@alien8.de> - 2016-11-01 13:20 +0100
  [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-05 14:20 +0100
    RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-07 18:50 +0100
      Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-07 19:10 +0100
        RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-07 19:40 +0100
          Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 19:10 +0100
            RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-08 19:30 +0100
            Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 21:50 +0100
              Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 22:10 +0100
                Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 22:20 +0100
                Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 22:30 +0100
                Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 23:00 +0100
                Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-09 19:10 +0100
  Re: [RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no  consumers Ingo Molnar <mingo@kernel.org> - 2016-11-07 08:40 +0100

csiph-web