Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1517606
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP |
| Date | 2016-11-08 23:00 +0100 |
| Message-ID | <sBmAW-6Em-15@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <sBj0m-4ko-35@gated-at.bofh.it> <sBlvb-5XM-19@gated-at.bofh.it> <sBlOx-6l2-21@gated-at.bofh.it> <sBlYd-6oS-1@gated-at.bofh.it> <sBm7U-6sU-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 8 Nov 2016, Borislav Petkov wrote:
> On Tue, Nov 08, 2016 at 10:14:04PM +0100, Thomas Gleixner wrote:
> > And yes, you should spend the extra cycles. Adding a flags argument to
> > mce_setup() and propagate it through the various callsites shouldn't be
> > that hard and would make the stuff obvious instead of obfuscated.
>
> Sure, that's already on my TODO. I want to take a look at it when I have
> a quiet moment.
So for now we should fold something like the below into this patch.
Thanks,
tglx
8<--------------------
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -706,6 +706,15 @@ bool machine_check_poll(enum mcp_flags f
mce_gather_info(&m, NULL);
+ /*
+ * m.tsc was set in mce_setup(). Clear it if not requested.
+ *
+ * FIXME: Propagate @flags to mce_gather_info/mce_setup() to avoid
+ * that dance
+ */
+ if (!(flags & MCP_TIMESTAMP))
+ m.tsc = 0;
+
for (i = 0; i < mca_cfg.banks; i++) {
if (!mce_banks[i].ctl || !test_bit(i, *b))
continue;
@@ -734,9 +743,6 @@ bool machine_check_poll(enum mcp_flags f
mce_read_aux(&m, i);
- if (!(flags & MCP_TIMESTAMP))
- m.tsc = 0;
-
severity = mce_severity(&m, mca_cfg.tolerant, NULL, false);
if (severity == MCE_DEFERRED_SEVERITY && memory_error(&m))
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no consumers Borislav Petkov <bp@alien8.de> - 2016-11-01 13:20 +0100
[PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-05 14:20 +0100
RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-07 18:50 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-07 19:10 +0100
RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-07 19:40 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 19:10 +0100
RE: [PATCH] x86/MCE: Remove MCP_TIMESTAMP "Luck, Tony" <tony.luck@intel.com> - 2016-11-08 19:30 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 21:50 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 22:10 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 22:20 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-08 22:30 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Thomas Gleixner <tglx@linutronix.de> - 2016-11-08 23:00 +0100
Re: [PATCH] x86/MCE: Remove MCP_TIMESTAMP Borislav Petkov <bp@alien8.de> - 2016-11-09 19:10 +0100
Re: [RFC PATCH 0/3] x86/RAS: Dump error record to dmesg if no consumers Ingo Molnar <mingo@kernel.org> - 2016-11-07 08:40 +0100
csiph-web