Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1518635
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails |
| Date | 2016-11-10 02:50 +0100 |
| Message-ID | <sBMF3-7dD-15@gated-at.bofh.it> (permalink) |
| References | <szAoF-2F9-3@gated-at.bofh.it> <szAoG-2F9-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/03, Sarangdhar Joshi wrote: > When devm_clk_get fails for core clock, the failure was ignored > and the core_clk was explicitly set to NULL so that other > remaining clocks can be queried. However, now that we have a > cleaner way of expressing the clock dependency, return failure > when devm_clk_get fails for core clock. > > Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org> Why can't this be folded into the second patch? It seems incorrect to allow it to silently work in patch 2 even though we've flagged that clk as a requirement and then change that behavior here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-11-04 01:20 +0100 Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Stephen Boyd <sboyd@codeaurora.org> - 2016-11-10 02:50 +0100
csiph-web