Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails
Date	Thu, 10 Nov 2016 02:50:01 +0100
Message-ID	<sBMF3-7dD-15@gated-at.bofh.it> (permalink)
References	<szAoF-2F9-3@gated-at.bofh.it> <szAoG-2F9-15@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1478742549; bh=2DyglDYMnUCJaiwrE2orrGeumpudQKDRX0EQGDNLcG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5GsrJ6aQHn/OUYLVmZHX9Ku6K7wCqaD7CP11Ycn4BU+StP13lKpfQ99RKkAdB+Nb MWQq/ue1iQpkWIQaK4d4n73cNOTEEXYhMVdnAdBAIg2aYGxPuJu5Fe6/zb3WEiMrEF u1Tv0NBZv6tQDRY9RriH4uVNoCw2Gx2sPTDJnxZs=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1478742549; bh=2DyglDYMnUCJaiwrE2orrGeumpudQKDRX0EQGDNLcG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5GsrJ6aQHn/OUYLVmZHX9Ku6K7wCqaD7CP11Ycn4BU+StP13lKpfQ99RKkAdB+Nb MWQq/ue1iQpkWIQaK4d4n73cNOTEEXYhMVdnAdBAIg2aYGxPuJu5Fe6/zb3WEiMrEF u1Tv0NBZv6tQDRY9RriH4uVNoCw2Gx2sPTDJnxZs=
Dmarc-Filter	OpenDMARC Filter v1.3.1 smtp.codeaurora.org 64B556126A
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	17
Organization	linux.* mail to news gateway
X-Original-Cc	Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Jordan Crouse <jcrouse@codeaurora.org>, Trilok Soni <tsoni@codeaurora.org>
X-Original-Date	Wed, 9 Nov 2016 17:49:08 -0800
X-Original-Message-ID	<20161110014908.GZ16026@codeaurora.org>
X-Original-References	<1478218237-1737-1-git-send-email-spjoshi@codeaurora.org> <1478218237-1737-4-git-send-email-spjoshi@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1518635

Show key headers only | View raw

On 11/03, Sarangdhar Joshi wrote:
> When devm_clk_get fails for core clock, the failure was ignored
> and the core_clk was explicitly set to NULL so that other
> remaining clocks can be queried. However, now that we have a
> cleaner way of expressing the clock dependency, return failure
> when devm_clk_get fails for core clock.
> 
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>

Why can't this be folded into the second patch? It seems
incorrect to allow it to silently work in patch 2 even though
we've flagged that clk as a requirement and then change that
behavior here.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Sarangdhar Joshi <spjoshi@codeaurora.org> - 2016-11-04 01:20 +0100
  Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when  devm_clk_get fails Stephen Boyd <sboyd@codeaurora.org> - 2016-11-10 02:50 +0100

csiph-web