Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515905

Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n

From Michael Ellerman <mpe@ellerman.id.au>
Newsgroups linux.kernel
Subject Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n
Date 2016-11-07 09:40 +0100
Message-ID <sANDb-tf-17@gated-at.bofh.it> (permalink)
References <szFy1-5RC-1@gated-at.bofh.it> <szJBE-hL-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Paolo Bonzini <pbonzini@redhat.com> writes:
> On 04/11/2016 06:48, Michael Ellerman wrote:
>> diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig
>> index da6e2ce77495..6b51a4ebed8a 100644
>> --- a/drivers/vfio/Kconfig
>> +++ b/drivers/vfio/Kconfig
>> @@ -6,12 +6,12 @@ config VFIO_IOMMU_TYPE1
>>  config VFIO_IOMMU_SPAPR_TCE
>>  	tristate
>>  	depends on VFIO && SPAPR_TCE_IOMMU
>> -	default n
>> +	default VFIO
>
> No need to depend on VFIO since you already have it in "default".

True, I can take that out.

> (I assume you cannot use "default y" because "depends on" doesn't downgrade
> "y" to "m" when VFIO is a module.

Correct.

> A shorthand is
>
> 	def_tristate VFIO && SPAPR_TCE_IOMMU

Yep. My experience though is that a lot of folks don't really know what
that means. So I prefer to spell it out with an explicit type, depends
and default.

But I'll respin it that way if Alex prefers the shorter style.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Michael Ellerman <mpe@ellerman.id.au> - 2016-11-04 06:50 +0100
  Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Paolo Bonzini <pbonzini@redhat.com> - 2016-11-04 11:10 +0100
    Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Michael Ellerman <mpe@ellerman.id.au> - 2016-11-07 09:40 +0100
      Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Alex Williamson <alex.williamson@redhat.com> - 2016-11-07 17:30 +0100
        Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Paolo Bonzini <pbonzini@redhat.com> - 2016-11-07 17:40 +0100
        Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Michael Ellerman <mpe@ellerman.id.au> - 2016-11-08 00:50 +0100
          Re: [PATCH] vfio: Fix build break when SPAPR_TCE_IOMMU=n Alex Williamson <alex.williamson@redhat.com> - 2016-11-08 01:10 +0100

csiph-web