Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515904

Re: [PATCH 1/2] irq,pci: allow drivers to specify complex affinity requirement

Show all headers | View raw

On 11/07/2016 12:07 AM, Christoph Hellwig wrote:
> Some drivers (various network and RDMA adapter for example) have a MSI-X
> vector layout where most of the vectors are used for I/O queues and should
> have CPU affinity assigned to them, but some (usually 1 but sometimes more)
> at the beginning or end are used for low-performance admin or configuration
> work and should not have any explicit affinity assigned to them.
> 
> This adds a new irq_affinity structure passed through a variant of
> pci_irq_alloc_vectors that allows to specify these requirements (and is
> extensible to any future quirks in that area) so that the core IRQ
> affinity algorithm can take this quirks into account.
> 
> It also removes the unused irq_affinity mask in struct pci_dev.  If we
> ever need that sort of functionality it should be passed through
> struct irq_affinity.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/pci/msi.c         | 61 ++++++++++++++++++++++++--------------------
>  include/linux/interrupt.h | 26 ++++++++++++++++---
>  include/linux/pci.h       | 14 ++++++----
>  kernel/irq/affinity.c     | 65 ++++++++++++++++++++++++-----------------------
>  4 files changed, 98 insertions(+), 68 deletions(-)
> 
Good idea.

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

support for partial irq affinity assignment Christoph Hellwig <hch@lst.de> - 2016-11-07 00:10 +0100
  [PATCH 1/2] irq,pci: allow drivers to specify complex affinity requirement Christoph Hellwig <hch@lst.de> - 2016-11-07 00:10 +0100
    Re: [PATCH 1/2] irq,pci: allow drivers to specify complex affinity  requirement Hannes Reinecke <hare@suse.de> - 2016-11-07 09:40 +0100
    Re: [PATCH 1/2] irq,pci: allow drivers to specify complex affinity  requirement Thomas Gleixner <tglx@linutronix.de> - 2016-11-07 17:00 +0100

csiph-web