Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467488

Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Aug 19, 2016 at 11:42:06PM +0800, Guodong Xu wrote:
> From: Xinliang Liu <xinliang.liu@linaro.org>
> 
> For debian linux, cma heap is used to allocate graphic buffers.
> The default size is 16 MB which is not enought.
> So increase the size to 128 MB.
> 
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)

This is a bad idea. You're increasing this heap for all users of the
default configuration (which on 64-bit ARM is everyone, really). Many of
the devices don't require the CMA except maybe for the occasional very
small buffer. Most implement some form of IOMMU support that removes the
need for large amounts of contiguous physical memory.

I think it's a better idea to have some bootloader append a cma=128 to
the kernel command-line if necessary.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-19 17:50 +0200
  Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Thierry Reding <treding@nvidia.com> - 2016-08-22 11:10 +0200
    Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-24 04:30 +0200

csiph-web