Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1467488

Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB

Path csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Thierry Reding <treding@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB
Date Mon, 22 Aug 2016 11:10:01 +0200
Message-ID <s8ToZ-4l2-13@gated-at.bofh.it> (permalink)
References <s7Uds-7rO-3@gated-at.bofh.it> <s7Uds-7rO-25@gated-at.bofh.it>
X-PGP-Universal processed; by hqnvupgp08.nvidia.com on Mon, 22 Aug 2016 02:02:03 -0700
MIME-Version 1.0
X-Nvconfidentiality public
User-Agent Mutt/1.6.2 (2016-07-01)
X-Originating-IP [10.2.70.221]
X-Clientproxiedby UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13)
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SkvwRMAIpAhPCcCJ"
Content-Disposition inline
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 50
Organization linux.* mail to news gateway
X-Original-Cc <catalin.marinas@arm.com>, <will.deacon@arm.com>, <arnd@arndb.de>, <horms+renesas@verge.net.au>, <olof@lixom.net>, <kuninori.morimoto.gx@renesas.com>, <alim.akhtar@samsung.com>, <srinivas.kandagatla@linaro.org>, <xuwei5@hisilicon.com>, <khilman@baylibre.com>, <riku.voipio@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, Xinliang Liu <xinliang.liu@linaro.org>
X-Original-Date Mon, 22 Aug 2016 11:06:01 +0200
X-Original-Message-ID <20160822090600.GB25947@ulmo.ba.sec>
X-Original-References <1471621328-21102-1-git-send-email-guodong.xu@linaro.org> <1471621328-21102-3-git-send-email-guodong.xu@linaro.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1467488

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Aug 19, 2016 at 11:42:06PM +0800, Guodong Xu wrote:
> From: Xinliang Liu <xinliang.liu@linaro.org>
> 
> For debian linux, cma heap is used to allocate graphic buffers.
> The default size is 16 MB which is not enought.
> So increase the size to 128 MB.
> 
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)

This is a bad idea. You're increasing this heap for all users of the
default configuration (which on 64-bit ARM is everyone, really). Many of
the devices don't require the CMA except maybe for the occasional very
small buffer. Most implement some form of IOMMU support that removes the
need for large amounts of contiguous physical memory.

I think it's a better idea to have some bootloader append a cma=128 to
the kernel command-line if necessary.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-19 17:50 +0200
  Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Thierry Reding <treding@nvidia.com> - 2016-08-22 11:10 +0200
    Re: [PATCH 2/4] arm64: defconfig: Set cma heap size to 128MB Guodong Xu <guodong.xu@linaro.org> - 2016-08-24 04:30 +0200

csiph-web