Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466237

Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration

Show all headers | View raw

On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote:
> The dmic-codec was registered within the platform_driver's probe function,
> which can cause deferred probe to run in loops as reported and analyzed by
> Russell King.
> 
> Use module_init/exit in the driver and handle the dmic-codec device
> registration and removal at that level instead of the platform_driver
> probe/remove.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Reported-by: Russell King <linux@arm.linux.org.uk>

I think this address came from memory... it's certainly not the one that
I'm using today. ;)

> ---

This certainly fixes the problem:

VUSB: disabling
mmcblk0: mmc0:0002 00000 972 MiB
ALSA device list:
 mmcblk0: p1 p2
  No soundcards found.
omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered
omap-abe-twl6040 sound: snd_soc_register_card() failed: -517
Waiting 2 sec before mounting root device...
EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem
EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended

and allows booting to continue.  Thanks.

Tested-by: Russell King <rmk+kernel@armlinux.org.uk>

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-08-19 08:40 +0200
  Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec  device registration Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-08-19 11:00 +0200
    Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device  registration Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-08-19 12:00 +0200
  Applied "ASoC: omap-abe-twl6040: Correct dmic-codec device registration" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-08-19 17:20 +0200

csiph-web