Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Russell King - ARM Linux Newsgroups: linux.kernel Subject: Re: [PATCH for 4.8] ASoC: omap-abe-twl6040: Correct dmic-codec device registration Date: Fri, 19 Aug 2016 11:00:02 +0200 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=vDq5ODlbY4EfLBGvyowxJMjbr4+1h+i5EXT/lowaVmU=; b=dUoVChSHf2dqO/PitiREtaczUZZ1wkmHDcgvcLoADmn30aZ/DIbCUEQm7IkrOcyNWoxknjAkGPyhkhUyUTlFlIKr8EERGWrkjEwBtSBV8+JgF2FUJep7wNbTAt19Nk39RJhgJP5x4A27GFaiRPPN/3OA7AVvkJE+NBjuRcpKIck=; MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 38 Organization: linux.* mail to news gateway X-Original-Cc: Mark Brown , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Tony Lindgren , misael.lopez@ti.com X-Original-Date: Fri, 19 Aug 2016 09:54:04 +0100 X-Original-Message-ID: <20160819085404.GI1041@n2100.armlinux.org.uk> X-Original-References: <20160819063424.16383-1-peter.ujfalusi@ti.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1466237 On Fri, Aug 19, 2016 at 09:34:24AM +0300, Peter Ujfalusi wrote: > The dmic-codec was registered within the platform_driver's probe function, > which can cause deferred probe to run in loops as reported and analyzed by > Russell King. > > Use module_init/exit in the driver and handle the dmic-codec device > registration and removal at that level instead of the platform_driver > probe/remove. > > Signed-off-by: Peter Ujfalusi > Reported-by: Russell King I think this address came from memory... it's certainly not the one that I'm using today. ;) > --- This certainly fixes the problem: VUSB: disabling mmcblk0: mmc0:0002 00000 972 MiB ALSA device list: mmcblk0: p1 p2 No soundcards found. omap-abe-twl6040 sound: ASoC: CPU DAI (null) not registered omap-abe-twl6040 sound: snd_soc_register_card() failed: -517 Waiting 2 sec before mounting root device... EXT4-fs (mmcblk0p2): mounting ext3 file system using the ext4 subsystem EXT4-fs (mmcblk0p2): warning: maximal mount count reached, running e2fsck is recommended and allows booting to continue. Thanks. Tested-by: Russell King -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.